I have set the Additional field to "do not collect" but it still shows up..

CommentFileSizeAuthor
#9 location_additional-441272_9.patch1.14 KBmrtoner

Comments

grafik’s picture

grafik commented
Component: Documentation » Code

I have the same problem

yesct’s picture

yesct commented

what is the date of the dev release you are using?

See #373924: Field settins are not applied

grafik’s picture

grafik commented

version: 2009-Apr-18

3rdLOF’s picture

3rdLOF commented

Same here

grafik’s picture

grafik commented

I have same problem with Drupal 5 site

nickbn’s picture

nickbn commented

Same problem.

Also does anyone know of a way to make the "State" field a dropdown instead of autocomlete?

yesct’s picture

yesct commented

nickbn, This issue is about the Additional Field. Is that the problem you have?

For your question about the state field, please create a new issue. Thanks! :)

nickbn’s picture

nickbn commented

YesCT-
Yes my problem is with the additional field. And I am using the latest version.

Thanks.

mrtoner’s picture

mrtoner commented
Title: Additional - do not collect » Additional - do not collect doesn't respect setting
Category: support » bug
StatusFileSize
new location_additional-441272_9.patch1.14 KB

Tell me if this works for you. Additional should display only if "Do not collect" is not selected and only if Street is also shown.

mrtoner’s picture

mrtoner commented
Status: Active » Needs review

It would be nice if I marked it for review...

grafik’s picture

grafik commented

mrtoner: working for me

andrewsuth’s picture

andrewsuth commented

Patch reviewed and works

+ should be added to the next DEV or RC

yesct’s picture

yesct commented
Status: Needs review » Reviewed & tested by the community
andrewsuth’s picture

andrewsuth commented

I've used about 4 patches on Location in the last few months - when is the next expected release?

yesct’s picture

yesct commented

I don't know. I wonder if brandon is having trouble?

jeffschuler’s picture

jeffschuler
Location Boulder, Colorado
commented

Patch in #9 worked.

vm’s picture

vm commented

Just applied the patch in #9 and can also confirm the additional field is now working as expected when set to do not collect.

BartVB’s picture

BartVB commented

#9 also worked for me. I do want to collect the street but collecting 'additional' doesn't really make sense in The Netherlands.

stefan81’s picture

stefan81 commented

Patch in #9 worked.
Can someone apply this to the head or current release?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

This works for me as well.

Steps tested:
1. Set street, city, state, postal code, country fields to "Allow" and the location name and additional fields to "do not collect"
2. Node form shows street, city, state, postal code, country fields (expected) but also shows "Additional" field (unexpected)
3. Applied patch - Additional field is no longer shown.

Further test:
1. Set street, and Additional, city, state, postal code, country fields to "Allow" and the location name to "do not collect"
2. Node form shows street, and Additional, city, state, postal code, country fields (expected) but also shows "Additional" field (unexpected)

In both cases I tried saving and editing nodes and both worked fine.

I agree with the RTBC status.

bdragon’s picture

bdragon commented
Status: Reviewed & tested by the community » Fixed

http://drupal.org/cvs?commit=303082
http://drupal.org/cvs?commit=303086
http://drupal.org/cvs?commit=303088

Fixed, thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Hervé Saladin’s picture

Hervé Saladin commented

Thanks, patch @ #9 worked fine for me too.
But there's more than one year since the stable version hasn't been updated, whereas the maintainers seem to be active and the dev version updated ...
What's going on ??? Do you need some help ? Can I do something ?