I couldn't believe it when I first saw it! I think it's generally bad practice to see this form on a new user account page. Though possibly convenient, you shouldn't hint at what features are on your site until *after* the user becomes an authenticated user.

Comments

jrabeemer’s picture

jrabeemer commented

And also, not everyone knows what gamertags are. People who don't know what this is will ask questions.

pobster’s picture

pobster commented

Well it's hardly a *feature*!!! I don't see why it's any different to the profile module collecting information on the registration form? All it does is to display something on your user page, you don't have to enable it in your filters.

Three options I'm considering;

  1. Simple permissions hook so you could disallow for anonymous users, enable for whoever else.
  2. Settings page - "display on registration form".
  3. Tell you to just disable the module as I'm actually *really* busy and tbh, I don't really care. I didn't write this module for you - I wrote it for me and thanks, it works nicely for exactly how I intended it to work.

Thoughts?

Pobster

thepita’s picture

thepita commented

Option 3 sounds perfect for some newbie pwnage

jrabeemer’s picture

jrabeemer commented

Come on guys, let's keep it civil. We all benefit from improving this module.

Both #1 and #2 sound really nice.

pobster’s picture

pobster commented

Well it's either one or the other? Both are sub-twenty lines of code...? I think I can handle that even though I completely disagree with it!

Pobster

pobster’s picture

pobster commented

Okay... I'm +1 for option 1... If you've no comments to make I'll proceed with a perm hook.

Pobster

jrabeemer’s picture

jrabeemer commented

#2 seems more obvious for noobs while #1 seems to handle more granularity, per role access. I don't feel too strongly either way.

pobster’s picture

pobster commented

The problem inherent with #1 is that you can't grant a permission across all the features. Example, yes disabling 'access gamertags' for anonymous users will prevent the form from displaying on the registration form but if you set the input filter for anonymous users... Then they'll have access to it when you've specified for them not to?

Pobster

thepita’s picture

thepita commented

I fail to see why its so important to have the option to remove it from the registration page. Almost every website you come across has fields which most people will skip. Also chances are the website that use's this module is somehow gaming oriented meaning 99% of user registrations will know what a gamertag is.

jrabeemer’s picture

jrabeemer commented

That's not true in my case. My site is a walled garden.

pobster’s picture

pobster commented
Version: 6.x-2.0 » 6.x-2.2
Assigned: Unassigned » pobster
Status: Active » Fixed

Done... Although I went with #2 rather than permissions in the end, reason being is that I think it'll encourage people to sell roles to enhance their sites and obviously, I'm against that... I hate to think that people make money out of stuff that I write for free.

Pobster

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.