Closed (fixed)
Project:
XMPP Framework
Version:
6.x-2.x-dev
Component:
XMPP-Framework
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Apr 2009 at 08:54 UTC
Updated:
5 May 2009 at 15:57 UTC
Hi,
It looks to me like xmpp_messaging is getting behind the messaging module.
At least xmpp_messaging_messaging needs an update, it should look more like :
/**
* Implementation of hook_messaging
*/
function xmpp_messaging_messaging($op = 'info') {
switch($op) {
case 'send methods':
$info['xmpp'] = array(
'title' => 'XMPP',
'name' => t('XMPP'),
'send callback' => 'xmpp_messaging_send',
'type' => MESSAGING_TYPE_PUSH,
'render' => 'xmpp_messaging_render',
'glue' => '',
'description' => t('Send XMPP using XMPP Framework.'),
);
return $info;
}
}
Basic change is using 'send callback' instead of 'send'. But I'm sure there is more to work out, as this doesn't make it work.
it looks like this in messaging mail:
function messaging_mail_messaging($op, $type = NULL) {
switch($op) {
case 'send methods':
$info['mail'] = array(
'title' => 'Drupal mail',
'name' => t('Mail'), // Name for display
'group' => 'mail', // Class of sending method
'destination' => 'mail', // Account property to use as destination
'type' => MESSAGING_TYPE_SEND, // Method type: push || pull
'glue' => "\n", // Glue for message body lines
'footer' => "\n--", // Separator for message footer
'description' => t('Send e-mails using the default Drupal mail library.'),
'send callback' => 'messaging_mail_send_msg', // Sending callback
'system accounts' => TRUE, // Supports multiple sending accounts
'account type' => 'mail', // The type of system account to use
);
return $info;
}
}
I can't find out what the extra elements are for - http://drupal.org/node/409614 appears to be out of date.
I'm going to continue on this - I have everything else working, i can send messages with xmppframework_send_message(), and notifications and messaging are working fine with other message types.
Any tips or pointers would be greatly appreciated.
Comments
Comment #1
darren.ferguson commentedxmpp_messaging will be coming out of this module and going into the messaging module hence that is where the new version will reside. It is just here currently until the final messaging module comes out then it will be removed from this dev branch.
Comment #2
samhassell commentedHi Darren,
FYI - In light of the move to messaging module, I created an issue over there - http://drupal.org/node/446922.
Regards,
Sam.
Comment #3
darren.ferguson commentedSam, the messaging portion is now in the new release of messaging module so it will be removed from the 6.2.dev branch of the XMPP Framework.