REALNAME module stops panel override from working

SocialNicheGuru - April 24, 2009 - 12:40
Project:RealName
Version:6.x-1.2
Component:Code
Category:bug report
Priority:critical
Assigned:Unassigned
Status:closed
Description

When using panels 3 to override any page, the override function of panels 3 does not work.

Through trial and error, I found that I had to disable RealName to get the basic functionality of panels to work.

Because I like Real name, I would love to use it in conjunction with panels.

Thanks,
C

#1

NancyDru - May 13, 2009 - 00:41

I have seen a similar complaint before and it was a Panels bug. I do not have Panels installed, and the only site I maintain that has Panels 2 does not use RealName.

#2

NancyDru - May 13, 2009 - 00:41
Status:active» postponed (maintainer needs more info)

#3

NancyDru - May 13, 2009 - 00:42
Priority:critical» normal

#4

SocialNicheGuru - May 13, 2009 - 04:01

Here is what was said as a possible cause.

http://drupal.org/node/441874#comment-1539910

Realname is a great module. i would love to use it in conjunction with Panels. I know I am not the only one.

Thanks again for a great module.

Chris

#5

NancyDru - May 13, 2009 - 14:12

No, certainly you are not the only one. I have other modules where the way Panels works interferes with their function.

In typical Earl fashion, he gives no details on how to "cooperate." Personally, I think properly using a theme function (and a core one at that) is cooperating.

#6

prdsp - May 19, 2009 - 13:59

Is there any followup to the last comment Earl posted here http://drupal.org/node/441874

It appears he is requesting more code information from you.

These are both great modules and it would be a real stinker not to be able to use them both.

Thanks for your efforts and contributions to the drupal community!

#7

mrjavum - May 27, 2009 - 16:49

I've wrote simple patch.
http://drupal.org/files/realname_ctools.patch

I am just learning PHP and Drupal...

#8

prdsp - May 27, 2009 - 17:29

This link just seems to go to the drupal home page...where is the patch?

#9

mrjavum - May 28, 2009 - 01:09

Try this link:

AttachmentSize
realname_ctools.patch 1.29 KB

#10

prdsp - May 29, 2009 - 00:35

Thanks mrjavum...I haven't checked the realname search functionality but everything else seems to be working with this patch. Just remember to check your permissions.

#11

charos - June 1, 2009 - 12:15

Is this patch going to be included in the dev release or it needs further evaluation?

#12

mrjavum - June 8, 2009 - 16:07

The new patch with more correct version detection of installed ctools.

AttachmentSize
realname_ctools_.patch 1.34 KB

#13

najibx - June 10, 2009 - 15:17

cool, patch works now. I have been wondering why panels was not taking over the user page !
thanks

#14

aschiwi - June 22, 2009 - 11:14

I can confirm this patch works - now Panels user view override works and user names are still being converted to real names.

#15

SocialNicheGuru - June 22, 2009 - 13:28

yes i can confirm also

#16

hiweed - July 6, 2009 - 06:40
Version:6.x-1.x-dev» 6.x-1.2

Yes the patch works great!
Please accept it.

#17

plan9 - July 10, 2009 - 17:36

mrjavum - please.... can you make a patch for 5.x?

#18

SocialNicheGuru - July 13, 2009 - 18:42
Priority:normal» critical
Status:postponed (maintainer needs more info)» active

With beta4 for panels I get this:

Fatal error: Call to undefined function delegator_get_task() in /sites/all/modules/realname/realname.module on line 168

Edit
change line in patch from
delegator_get_task to
page_manager_get_task

and enable page_manager which is a new module in ctools

#19

SocialNicheGuru - July 13, 2009 - 18:42
Status:active» fixed

#20

SocialNicheGuru - July 15, 2009 - 16:22
Status:fixed» active

Realname is not working with the following just in case people have installed and are having problems
It causes a white screen of death on the /user page

I know they are dev versions, but they usually have the latest bug fixes etc.

panels
; Information added by drupal.org packaging script on 2009-07-15
version = "6.x-3.x-dev"
core = "6.x"

chaos tools (ctools)
; Information added by drupal.org packaging script on 2009-07-14
version = "6.x-1.x-dev"

#21

merlinofchaos - July 22, 2009 - 01:29

There is now an easier way to take over the fallback than this. Here is code from nodecomment.module designed to do exactly this:

First, it doesn't take over the menu if it knows ctools will:

<?php
function nodecomment_menu_alter(&$items) {
 
// Override the node view handler for our purpose.
 
if (!module_exists('delegator') && !module_exists('page_manager') && $items['node/%node']['page callback'] == 'node_page_view') {
   
$items['node/%node']['page callback'] = 'nodecomment_node_view';
  }
?>

Second, it tells page manager it can handle the default case:

<?php
/**
* Ask Delegator to use our version of the node page view instead of
* Drupal's when falling back.
*/
function nodecomment_delegator_override($type) {
 
// Continue to support the older delegator module by passing thru
  // to the newer function:
 
return nodecomment_page_manager_override($type);
}

/**
* Ask Page Manager to use our version of the node page view instead of
* Drupal's when falling back.
*/
function nodecomment_page_manager_override($type) {
  if (
$type == 'node_view') {
    return
'nodecomment_node_view';
  }
}
?>

This works with both the older delegator AND page manager so you don't need a gap in functionality.

#22

prdsp - July 23, 2009 - 20:25

It doesn't work with the RC1 releases either...page just goes white. Can anyone revise the patch to include the code that merlin posted?

#23

nickbn - August 5, 2009 - 19:37

I am willing to pay a bounty to have this issue fixed. Whatever method is used to fix this issue I would like added to respective module's future releases. Contact me directly or reply if interested. I'm ready to pay as soon as tomorrow (Aug. 6th 2009) I need this ASAP.

Thanks!

#24

cgillogly - August 12, 2009 - 14:36

The last patch by @mrjavum worked before ctools beta4, which switched to the page_manager module and removed the delegator module. So here is a new patch that should allow it to work with either delegator or page_manger.

AttachmentSize
realname_ctools.patch 1.47 KB

#25

abaddon - August 25, 2009 - 20:39
Status:active» needs review

regarding merlinofchaos's comment from #21, the proper rewrite of this patch is attached to this message, im using it without any issues till now on a live site
applies against 6.x-1.2 with from within the realname module's directory (-p0)

this should be included into realname, anything against this?

AttachmentSize
realname_ctools.patch 1.49 KB

#26

aschiwi - August 26, 2009 - 07:50

@abaddonsun - The patch works for me too - I started using Realname 6.x-1.x-dev and ctools 6.x-1.0-rc1. After I knew this worked I "upgraded" to Realname 6.x-1.2 and ctools 6.x-1.0 and this also worked. Thank you!

#27

ayalon - September 8, 2009 - 13:26

I applied the patch in #25 and it works as expected. My vote to add this t the next release.

#28

ianchan - September 30, 2009 - 02:07

subscribe

#29

ayalon - September 30, 2009 - 21:23

Please commit the patch in #25. This is the second time I stumbled over this.

#30

NancyDru - September 30, 2009 - 23:44

It is not marked RTBC.

#31

ianchan - October 1, 2009 - 00:29

Patch from #25 worked for us. Thanks!

#32

aschiwi - October 1, 2009 - 07:11
Status:needs review» reviewed & tested by the community

Hey Nancy, I'm not sure who would be the best person to mark an issue RTBC but I thought it was the module maintainer. The patch seems to work for everyone without problems. I still have it running on several installs without problems. I'm marking it RTBC now, please don't yell at me if I wasn't supposed to :-)

Anja

#33

NancyDru - October 1, 2009 - 07:16

The correct person would be the second or third person who thoroughly tested and approved it. That means you are an appropriate person. I will try to remember to commit it in the morning.

#34

NancyDru - October 1, 2009 - 14:31

Well, I was going to commit this as part of #579040: Some bugfixes, but someone now says that there is an issue that is outstanding against that patch.

#35

NancyDru - October 1, 2009 - 15:29
Status:reviewed & tested by the community» fixed

Fixed by #579040: Some bugfixes.

#36

NancyDru - October 14, 2009 - 23:13
Status:fixed» closed

Included in 6.x-1.3

 
 

Drupal is a registered trademark of Dries Buytaert.