Download & Extend
Login Destination » Issues

conflict at login with legal module

Posted by matteoraggi on April 28, 2009 at 4:19pm
Project:Login Destination
Version:7.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work

Issue Summary

in my login destinatin module I have setted to go at this path after login http://www.forniture-alberghiere.net/ dashboard/3
but when legal module is acting with a new agreement to accept, he force the redirect to the view of users area, in my case http://www.forniture-alberghiere.net/ users/estufe I hope that colaborating with author of http://drupal.org/project/legal module you can patch soon this simple but big problem.
Here direct link to contact him:
http://drupal.org/user/3555/contact

Login or register to post comments

Comments

#1

Posted by matteoraggi on April 30, 2009 at 7:22pm

If someone find the same problem that I was having, you can find the patch of legal module here:
http://drupal.org/node/447476#comment-1539240
hoping that after version 6.x-2.2-beta4 this patch will be added to code.

#2

Posted by rsvelko on February 14, 2010 at 12:59pm

posponed

#3

Posted by rsvelko on February 14, 2010 at 2:38pm
Status:active» postponed

#4

Posted by oskar_calvo on January 12, 2012 at 9:13pm
Status:postponed» active

what about this bug?

Oskar

#5

Posted by rooby on February 3, 2012 at 5:05am
Version:6.x-2.3» 7.x-1.x-dev
Status:active» needs review

Here is a patch that fixes it for me in drupal 7.

Note that this won't port directly to drupal 6 as is because the hook_drupal_goto_alter() method of redirecting isn't used in drupal 6 (and can't be as the hook doesn't exist in drupal 6).

It might give someone direction on making a drupal 6 patch though (I haven't looked at the D6 code).

AttachmentSize
login_destination-legal-447480-5.patch 888 bytes

#6

Posted by rooby on February 3, 2012 at 5:06am

By the way, the drupal 7 symptoms are that the login destination redirect overrides the legal module's drupal_goto(), which means the user isn't sent to the legal page and they are logged out again silently.

#7

Posted by mithy on February 4, 2012 at 4:15pm

@robby. Thank you for your continuous patches. However the root of this problem is a flawed way in which the Legal module handles logins and I will refrain from adding an error-prone hack in LD to fix it:

The problems in Legal module are:

  1. It calls drupal_goto in the login process. It has been discussed many times in this queue why it is not a good idea. It should alter the drupal_goto instead, same as LD module does.
  2. It logs the user out in user_login, if the terms were not accepted. Of course all modules assume that the user is logged in on this place and perform their actions (which is redirect in case of LD). This should be handled in user_validate instead.

#8

Posted by mithy on February 4, 2012 at 4:15pm
Status:needs review» needs work

#9

Posted by rooby on February 5, 2012 at 12:51am

I see your point.
I'll have a look at doing a patch on the legal side of things. It definitely should be doing it's work in the validation stage.

On a side note, this is the first time I've seen the goto alter hook. It's a nice addition.

#10

Posted by mithy on February 10, 2012 at 8:02pm

Definitely! Without this hook there is no way to do login destinations right. That's why it will never work for d6. This thread #761254: not working with content profile module ? has some explanations.

I posted about this bug in the queue of Legal module (#447476: conflict at login with login_destination module).

#11

Posted by oskar_calvo on February 10, 2012 at 9:10pm

I think that one of the module should build a hook and the other one check this hook or will not way to resolve this problem.

Oskar

#12

Posted by mithy on February 11, 2012 at 10:11am

The problem can be solved without a hook and this is really not a time for major changes in API.