Download & Extend
Fivestar » Issues

"Allow user to clear value" checkbox always checked

Posted by jenlampton on April 28, 2009 at 10:23pm
Project:Fivestar
Version:6.x-1.13
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

fivestar_field.inc line 193.

'#default_value' => $widget['allow_clear'] ? $widget['allow_clear'] : 1,

will always reset this form element to true. It should be something like
'#default_value' => ($widget['allow_clear'] == 0) ? $widget['allow_clear'] : 1,

or perhaps
'#default_value' => $widget['allow_clear'] ? $widget['allow_clear'] : 0,
Login or register to post comments

Comments

#1

Posted by quicksketch on April 29, 2009 at 8:41pm
Status:active» fixed

I've committed the attached patch to fix this.

AttachmentSizeStatusTest resultOperations
fivestar_allow_clear.patch714 bytesIgnored: Check issue status.NoneNone

#2

Posted by jenlampton on May 1, 2009 at 8:15am

Thanks :-)

#3

Posted by System Message on May 15, 2009 at 8:20am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.