"Allow user to clear value" checkbox always checked

jenlampton - April 28, 2009 - 22:23

Project:	Fivestar
Version:	6.x-1.13
Component:	Code
Category:	bug report
Priority:	normal
Assigned:	Unassigned
Status:	closed

Jump to:

fivestar_field.inc line 193.

'#default_value' => $widget['allow_clear'] ? $widget['allow_clear'] : 1,

will always reset this form element to true. It should be something like

'#default_value' => ($widget['allow_clear'] == 0) ? $widget['allow_clear'] : 1,

or perhaps

'#default_value' => $widget['allow_clear'] ? $widget['allow_clear'] : 0,

» Login or register to post comments

#1

quicksketch - April 29, 2009 - 20:41

Status:

active

» fixed

I've committed the attached patch to fix this.

Attachment	Size
fivestar_allow_clear.patch	714 bytes

Login or register to post comments

#2

jenlampton - May 1, 2009 - 08:15

Thanks :-)

Login or register to post comments

#3

System Message - May 15, 2009 - 08:20

Status:

fixed

» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

Login or register to post comments

Drupal is a registered trademark of Dries Buytaert.