You should never never use define together with the t function:

see http://drupal.org/node/317001

this is a performance disaster, the language cache is rebuild every time, so here is a patch

thx :)

perhaps the t function should be left of variable_get

CommentFileSizeAuthor
buymeabeer-not-definie-t.patch1.56 KBdawehner

Comments

yaph’s picture

Thanks for the patch. I removed the calls to t() within define calls and moved it to variable_get. Is there any evidence that t() should not be used in variable_get as well?

yaph’s picture

Assigned: Unassigned » yaph
Status: Active » Fixed
avpaderno’s picture

Title: define( with t » Don't use t() inside define()
Category: feature » task
yaph’s picture

Fixed in release buymeabeer 6.x-1.1-beta3 http://drupal.org/node/448228

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.