In Trouble shooting Simpletests it suggests $this->pass($this->drupalGetContent());

I get Strict warning: Only variables should be passed by reference in weblinks_filter_process() (line 91 of C:\www\webapps\drupal-6\sites\all\modules\contrib\weblinks\contribs\weblinks_filter\weblinks_filter.module).

Comments

boombatower’s picture

boombatower commented

Interesting...I was not involved in writing that. Well as a note I prefer:

file_put_contents('output.html', $this->drupalGetContent());

since you can then just view in web browser and put as many pages in there as you want by adding FILE_APEND flag.

I point it out and see what the consensus is on updating the doc.

boombatower’s picture

boombatower commented
Assigned: Unassigned » boombatower
Status: Active » Fixed
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

How do we browse the output.html file? Where is it created?

@nancy: Does this pass the strict check?

$content = $this->drupalGetContent();
$this->pass($content);

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Yes, that passes strict test and that's what I did.

You can download Web Links 6.x-2.x-dev and run the tests your self, but they now work, so you would have to change those lines back.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.