Spaces are removed from CSS definitions

My issue is a duplicate of this one. Sorry. Subscribing. Here was my writeup:
http://drupal.org/node/475830

I might also add, that it looks like the code your fix is applied to is meant to strip out multiple white spaces, but actually strips out all whitespaces. Maybe the code should be more like:
$variables['css'] = str_replace('  ',' ', str_replace("\n", '', $css));?

I was having the same issue. I have made the modification suggested by gregarios and now the css in my newsletters looks correct and is interpreted correctly by the mail clients I've tried so far.
Thanks for pinpointing the fix mindgame and gregarios.

I'm bumping this to critical, then... since this is a show-stopper bug and a fix is in this post.

Changing to "needs review" since a patch is attached.

Also see #443964: media=<print|screen|all> selector stripped from mime_mail embedded css

me fail sorry about that

Thanks for the hint.

I didn't check the later patch, but the very first solution seams just fine for mime mail's core module. (Because spaces are part of the CSS selector syntax, removing any of them without semantical parsing seems fatal in any case.)

Which solution is the "very first solution" you are referring to? "Multiple spaces" are not part of CSS in any way.

I'm referring to the one in mindgame's original post: Multiple spaces are not, but single spaces are.

I opened a different case, namely: #581142: truncated mail due to css

My original issue was not css space removement, but much more mail truncation.

Please please read my post and understand that removing any newline is NO solution for SMTP due to RFC limitation of 998 bytes line length.

So finally i see no gain in removing a few bytes such as newlines and spaces, except introducing an incredible amount of potential problems. Instead mimemail should implement line length checks and add them manually or do base64 encoding...

Please simply switch this to the full unmodified css content.

+1 for #10

Please simply switch this to the full unmodified css content.

I'm ALL for that! Please, Allie Micka, or one of the other maintainers...

Good point, Miro.

Here's the patch for the latest dev release (2009-Jun-08):

Here's the patch for the latest dev release (2009-Jun-08):

I think having it remove multiple spaces (leaving all as single spaces) is still a good thing. Leave line-endings though. can you update the patch to reflect what I wrote in the space-removal part of #2?

@gregarios. Here you go. I can't test the patch myself for now. Could you please verify that this works? Thanks, Moritz

The patch in #16 doesn't seem to do anything.

In testing, I tried a few mods myself to see if I could get it to work right. The string you are modifying doesn't seem to do anything at all. Even if I change it to be like the patch in #14, there is no change... all the CSS is still compressed.

I believe the fault lies in the mimemail_compress modules. I've tracked down another somewhat related issue to this, where certain CSS containing links gets corrupted as well:

background-image: url(http://domain.com/image.jpg);
turns into:
background-image:url(http;

Somehow, in the mimemail_compress.inc file, there is code that is reading all colons as CSS seperators, and using the colon in a URL incorrectly, causing it to be corrupted.

I believe all the substitutions with whitespace are also done in the mimemail_compress.inc file as well... could you take a look in it? I tried to spot the defects, but could not due to my lack of enough PHP experience.

UPDATE I believe the string list($key,$value) = explode(':',$def); found in the mimemail_compress.inc file may be to blame for all CSS URL corruption.

gregarios:
This issue is NOT about mimemail_compress. It's about wrong behaviour of plain mimemail.module - without mimemail_compress activated.

After having this basic functionality fixed you might think about enabling mimemail_compress (and also look into depth of much other strange things it does ;-) ) .. You don't need mimemail_compress. I strongly recommend you to add an own mail.css file and get rid of other css definitions that way.

@miro_dietiker:
My mistake... the last patch (in #16) does work.

*whew* Thanks for testing @gregarios

*whew* Thanks for testing @gregarios

As a matter of fact I disabled the CSS Compress module at your suggestion and went with a mail.css file. WAY happier with the results. :-) (Now I wish mail.css could be named differently, but oh well.)

Alas, this has not been fixed in the newest version... and the patch in #16 would appear to not work on this version as well.

The patch needs to be rewritten to work on the same BUG CODE which has been moved to the mimemail.theme.inc file now. Disappointing.

Here we go @gregarios. For future reference: http://drupal.org/patch/create ;)

Thanks omo for the patching help. Your patch works great! Now, how can we get this into alpha2? :-)

Patch works as advertised. Let's move this one in.

For a CSS code cleaning, this line it's better :

- remove all space before and after CSS separator : ":", ";", "(", ")" and ","
- replace multiple spaces and similar (\n, \r, etc.) by one space

Patch with comment #28

Patch for comment #27:

I don't think we should do any complex css cleanups in here.
Just make it work as minimal as possible. Without need to check complex specific replacements to understand if it works now or if it still doesn't in some specific cases.

Specific advanced cleanups should be integrated the way as css Compressor module does.