Hi,

I know this might be unnecessary, but it does make it easier to read through the code and use coder to identify true issue, so I have put together a patch that cleans up the majority of the coder reported issues, coding standards, etc, and also added a few TODOs for a few sections that could be improved.

Chances are I will submit a few more patches for things to do with improving integration with FileField Paths and ImageField Tokens and those patches will rely on this patch.

Cheers,
Deciphered.

CommentFileSizeAuthor
#1 image_fupload-HEAD-450250-code_cleanup-2.patch125.66 KBdeciphered
image_fupload-HEAD-code_cleanup-1.patch124.4 KBdeciphered

Comments

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented
StatusFileSize
new image_fupload-HEAD-450250-code_cleanup-2.patch125.66 KB

Missed a couple changes on my merge.

Updated patch attached.

grandcat’s picture

grandcat commented

Great! As I can see, you did a very good job, thank you very much.
I will take a closer look at the changes before submitting to CVS Head.

grandcat’s picture

grandcat commented
Priority: Minor » Normal
Status: Needs review » Postponed

Will be done soon.

grandcat’s picture

grandcat commented
Status: Postponed » Fixed

Submitted to CVS Head. Deciphered, thank you.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.