Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Add a table too the sms module that will hold the country codes for international dialing that way the sub modules do not have to re-do the same code over and over again. Currently sms clickatell supports the country code module and other sub modules which can be created would have to also create the same information if they wanted to utilize international numbers which causes a lot of over head having to continually parse for no reason even if the smsframework is not being used at that time.
Attached patches and file for install i am hoping will allow this to be addressed in the system. Will make a patch for the clickatell module regarding this functionality in a seperate issue and link them.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | smsframework-453126.patch | 1.04 KB | darren.ferguson |
| #1 | sms.install.patch | 5.93 KB | darren.ferguson |
Comments
Comment #1
darren.ferguson commentedAttached is the patch for the smsframework in order to have the function retrieving the information from the table.
Also attached is the .install file for the sms module.
Comment #2
mfbIt seems like a very good idea to me to have a unified database of country codes.
(More controversially I would even like smsframework to have a unified database of carriers, which would allow a site to switch gateways...)
Comment #3
mfbBy the way, here's a thought I recently had:
If you are using the e-mail gateway and needed the country code of a user (for example to be able to call the user, or to be able to switch to some other SMS gateway), we'd be able to figure out if there's a one-to-one mapping between carriers and country codes. If this is the case, then we'd just need a database or data structure providing this mapping.
Comment #4
univate commentedFirstly completely agree with have country codes in a central place. But don't think they need to go in the database, its not like they will be changing often or different for different sites. I have committed a change that moves the country function from the sms_clickatell module to the sms module