Move checker to contrib

That sounds like a good idea. I have currently got a patch which adds a bit of extra functionality and more options to the checker. I probably would have posted it here in a few days time, just doing some testing on it now. Would you like me to move the code to a sub-module in the same patch? Or should I check with you that you want to include my additions first, get them done and committed, then we move it to a sub-module after?

Jonathan

jonathan1055,

Please do the patch against current code. I prefer 10 smaller signal step patches to 1 larger doing 10 thing patches.

NancyDru,

I agree this is a great idea to move this out. I would like to see this done before 6.x-2.x is released. After the problems with had when I moved weblinks_blocks out I think something like this need to be done in a major version change.

Thanks
Robert

Hi Nancy,

In re-making my checker enhancements, I found a slight problem in weblinks_checker_validate() due to the code being moved out from weblinks_form(). The $node object is not directly available in weblinks_checker_validate() so the URL duplication test for $node->nid != $url_exists_nid is always true and the duplicate error/warning is always triggered. Hence you can't actually add a new weblink or edit an existing one.

It is simple to fix, because $node->nid can be replaced with $form['#node']->nid

The attached patch makes this change, and also removes a trailing space on a previous line (as per coding standards courtesy of the coder module standards checker). I rolled it from the weblinks main directory, is that right?

I wasn't sure of the etiquette of re-opening a fixed patch, but seeing as it was only recently fixed, I thought this was the best place to report this.

Jonathan