Solr_Base_Query::*_field() are now Solr_Base_Query::->*_filter().

CommentFileSizeAuthor
#3 455646-project-apachesolr-update.patch3.03 KBdamien tournoud
#1 455646-project-apachesolr-update.patch2.8 KBdamien tournoud

Comments

damien tournoud’s picture

damien tournoud commented
Status: Active » Needs review
StatusFileSize
new 455646-project-apachesolr-update.patch2.8 KB

Patch attached.

dww’s picture

dww
we/he/they
commented
Status: Needs review » Needs work

Minor nit:

+  foreach ($query->get_filters() as $field) {

If Solr now calls this a "filter", I'd rather the variable was "$filter", too, instead of "$field".

Otherwise, if it works, ship it. ;)

damien tournoud’s picture

damien tournoud commented
StatusFileSize
new 455646-project-apachesolr-update.patch3.03 KB

I'm going to commit the attached.

dww’s picture

dww
we/he/they
commented
Status: Needs work » Reviewed & tested by the community

Looks great, thanks.

damien tournoud’s picture

damien tournoud commented
Status: Reviewed & tested by the community » Fixed

Committed.

damien tournoud’s picture

damien tournoud commented
Status: Fixed » Needs work
Issue tags: +needs drupal.org deployment
dww’s picture

dww
we/he/they
commented
Status: Needs work » Active
Issue tags: -needs drupal.org deployment

Previous has been deployed. Back to active since there are a few other API changes DamZ wants to investigate and possibly take advantage of now that we're using the latest Solr on d.o...

dww’s picture

dww
we/he/they
commented
Status: Active » Closed (fixed)

This now is closed, especially given #679060: Project Solr: cleanup the API in preparation for the redesign

damien tournoud’s picture

damien tournoud commented

That was a old one :)