Color panes feature

+ /* This prefix/suffix hack below can't be the best way to do this... Should
+ * I be using a CTools AJAX respond command? I wasn't sure how to set this
+ * up
+ */
+ '#prefix' => '

Drupal.Panels.Color.addFarbtastic("#pane-'.$pid.'");

',
+ '#suffix' => '

',

This should be done with a behavior, probably in color.js that looks something like this:

Drupal.behaviors.PanelsColorSettings = function() {
  $('.some-class-to-signify-farbtastic-should-be-attached:not(.panels-color-processed)')
    .addClass('panels-color-processed')
    .each(function() {
      Drupal.Panels.Color.addFarbtastic($(this).attr('id'));
    });
}

Roughly.

Second, we probably shouldn't name it color.js as themes can override javascript files (at least, they can with css files and I think javascript is the same way) and color.js is too generic. Let's name it panels-color.js

I'll have more later, but that's clearly the big messy thing that can be cleaned up.

+function panels_render_print_color_css($style, $display, $idstr, $where) {
+  ctools_include('css');
+  $css_id = 'color_panels:' . $idstr;
+
+  $css = _panels_render_print_color_css($style, $idstr);
+  /* Unfortunately for now we're doing this the older/uglier way
+   * Otherwise proper cache files will have to be flushed when settings
+   * are changed */
+  drupal_set_html_head("<style type=\"text/css\" media=\"all\">\n$css</style>\n");  
+}

Instead of this, we can use CTools CSS caching functions.

We can use ctools_css_clear() when the style settings form is submitted and ctools_css_retrieve() to get the filename and ctools_css_store() if it doesn't come up with a filename. That should cover all of our bases. All we need to do is be sure to come up with a unique ID -- you can look at how the 'rounded corners' style does it, which has to solve the exact same problem.

I have not tried this patch yet, but colored panels would be amazing! I will definitely keep an eye on this.

Very cool. Subscribing

+1 Suscribing

+1 Suscribing

Just wondering if there are any updates for this patch, I know you are probably very busy Slip, just wondering if this will still be moving forward. It Sound really great
Regards, Lowell

This would be really cool. But how should I use this patch? Where should I copy it? Please give me instructions. Plz plz plz

drupal-boss - May 31, 2009 - 19:20
This would be really cool. But how should I use this patch? Where should I copy it? Please give me instructions. Plz plz plz

Have you seen this documentation ? http://drupal.org/node/60108

Thanx

Thanks for your response Slip. Looking forward to the patch if and when you get time to post it.
The extra functionality your working on sounds great. I am not versed with panels enough to help with the patch, but I would certainly be willing to help with testing where I can.

+1 Suscribing

Hey slip, any updates? If you're very busy, could you at least post a patch with your most recent work? It could be valuable if somebody else wants to finish it. =)

Slip, some time ago I fiddled around with transparent, rounded corners for a panel style and eventually made it work. It might give you an idea of an approach you might use: http://drupal.org/node/218960#comment-864840. If you keep the rounded corners transparent, you can change the color of the theme or the panels and still have things match up.

follow

Slip, thank you for the patch. I am trying to test, but I'm having trouble applying the patch. I am trying to patch against 6.x-3.0 beta 4, and I've put the patch into my panels module folder. Using the command "patch < color-panels.patch" the patch cannot find the files it's supposed to update. My apologies for my lack of understanding here, but I would really like to try this out. Any help in applying this patch would be appreciated. I would also work with a pre-patched tarball, if you are inclined to post that here. Thanks, Slip.

He made it from the modules directory, ont panels; try patch -p1

Merlin, thank you. The -p1 command did the trick for patching with the patch file in the panels module directory.

It's best generate patches from inside the module directory as most folks are used to using -p0. If it's easier to do it this way it is fine.

I played with this for a few minutes (wanted to do longer but I'm a little too tired to work on something so involved) and on first review, this really spews notice errors. I recommend turning E_NOTICE on (I think you edit bootstrap.inc to do this) and you'll see what I mean. Most of it is unquoted strings in the .inc files but there appeared to be some tests for non-existing variables in display-edit or display-render

In trying this, my panels admin links vanish from the main dashboard (except for the links under the "By module" page) and the panels page configuration links were missing from here as well. Reverting back to beta solved the problems, so I'm guessing there are some issues to be resolved with this patch. I am using a local install of Drupal with XAMPP on a Windows Vista machine and the rootcandy admin theme, so my install is somewhat unique. I am really looking forward to this functionality in panels, so hopefully the bugs can get ironed out and this can eventually get added to the development branch. I will retest with the next patch.

I switched to Garland, but I still do not get a panels admin link for adding or listing panels pages. This is with your latest patch. I also get an unsupported operands error when trying to add a new panel page. If I go to http://localhost/mysite/admin/build/panels, I simply get the list of other site-building links. Also, if I try admin/build/panels/settings/panel-page, I cannot get to the settings for panel pages (it just goes to the base site building page that lists the links to other module's settings).

Slip, it appears that I needed to disable the panels module, uninstall the panels module, delete the old panels folder, replace it with the patched version of panels, then enable and reinstall panels. This made the admin links appear in their proper place. I'll give you another update after further testing. I've downloaded the image file to the prescribed location and I'm trying out the styles. Thanks again for working on this.

The color panel has notched corners at this point. See the attached image.

It looks like the color panes work really well. I just can't get the rounded corners to look rounded at this point. Is the image you posted earlier the right image?

Maybe related to your earlier comment on caching, it would be nice to be able to save a certain pane or panel style, name it, and then reuse it with other panels or panes.

bomarmonk: Yes, that's on the list of things that we'll want to do as this feature matures. Probably for a later issue though.

Slip, I get a notched edge, not a rounded corner. I am using the rounded style and the colors are changed appropriately. It just looks like the old Atari 2600 days with low resolution sprites. It might have to do with the image file. I'll try updating that file. Maybe I saved it incorrectly or something.

I think that's the problem-- the folders are there, but there aren't any files in them. I'll try to fix this. A warning, as you mentioned, would help people like me to get this working.

Slip, my install reports that the GD toolkit "is installed and working properly." The images are generated normally for my theme (which uses the color module). I'll try creating another rounded corner pane and see if I can give you any more information about the trouble I am having.

Hi! I just install panels-RC1 with your last patch and put png file. I can't see anything new in panels (nothing colors) except this error: file_get_contents(sites/all/modules/panels/panels/js/panels-color.js): failed to open stream: No such file or directory /var/www/apache2/html/includes/locale.inc string 1689.

Could you please attach patched version of RC-1 Panels?

Sorry, it was my problem. Now i see color panes feature.

Please, attach patched version.

I think it'll be very coll, if we can choose corner color. I mean to colors for colored round corners: one for body and one for round corner.

subscribing

Slip, great patch!

Just a quick note, I can partly confirm the problem posted by bonarmonk. The problem is probably not GD related, because some of the rounded corners work. If I just select rounded corners for a region -> everything is alright. The problems start when I try to nest rounded corners like you did in your screenshot.

If I select rounded corners in different colors for both region and content, the inner corners only work, when "each region" is selected in the container dropdown. Otherwise the corners are broken like in the screenshot.

Also the "color panes" do not seem to apply fill settings.

subscribing

> Also the "color panes" do not seem to apply fill settings.
What do you mean by fill settings?

Something like this (maybe there were some changes in panels?). Just a quick hack to illustrate, what wasn't working, maybe other classes are better.

/panels/plugins/styles/color_panels/color_panels.inc (working copy)
@@ -24,16 +24,16 @@
                        'selector' => array('.inner-pane'), 'attr' => 'border',
                        'additional' => '1px solid'),
                  array('label' => 'Background', 'default_value' => '#FFFFFF',
-                       'selector' => array(), 'attr' => 'background-color'),
+                       'selector' => array('.inner-pane'), 'attr' => 'background-color'),
                  array('label' => 'Header Background',
                        'default_value' => '#3D9CD7',
-                       'selector' => array('h2.title'),
+                       'selector' => array('.pane-title'),
                        'attr' => 'background-color'),
                  array('label' => 'Header Text Color',
                        'default_value' => '#FFFFFF',
-                       'selector' => array('h2.title'), 'attr' => 'color'),
+                       'selector' => array('.pane-title'), 'attr' => 'color'),
                  array('label' => 'Text Color', 'default_value' => '#000000',
-                       'selector' => array(), 'attr' => 'color'),
+                       'selector' => array('.inner-pane'), 'attr' => 'color'),
                ),
       'hook theme' => array(
         'panels_color_panels_box' => array(

What do you think about introducing border color for the colored rounded corners?

Thank you for nice work !
subscribing....

What is the status?

would it be possible to integrate with the color picker module? just a thought.

Thanks for the basic work on this, slip.

I just dedicated the last 2 weeks to bringing this one home. I have checked it in, and some of it is in CTools and some of it is in Panels.

If you cvs up CTools and Panels, you can activate the panels stylizer module. Currently it needs a few more styles, which I hope to get from volunteers who are a little better with photoshop than I am.

It also needs some documentation. I'll try to work on that this week.