Posted by coupet on May 8, 2009 at 4:25pm
| Project: | Multiple E-mail Addresses |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Great module; Any plan for 6.x?
Comments
#1
Subscribe
#2
Is compatibility for version 6 planned ?
#3
Hello - i ported this module to d6. It it a first version please test it and give feedback. I added some new features: Like a admin-permission. now this module is based on the user-path. I have delete many messages like "E-Mail Adresse not found." or "Your are not allowed to edit this email address" now it displays an access denied ...
Please explore and test.
Important Notice: If you use the me-module you have to exclude this module from its path. Add something like this: user/*/edit/email-addresses*
#4
Upload does not work. Here is the file
#5
#6
Any news ?
#7
No this port is not ready. Cant work on this in the past. Maybe i can finish this port next week. Maybe you can test and review?
#8
I'll test and review this port. Thanks for getting this started!
#9
Hi i started the port. I uploaded the current version on github. http://github.com/webflo/multiple_email
Please test and give feedback.
thx flo
#10
Flo, thanks for working on this.
I find that if I add two e-mail addresses and then click the confirmation link for one of them, then e-mail is sent to both of the new addresses, each with its own confirmation code.
By the way, the comment form does not give me the option of listing 6.x (nor 6.x-1.x-dev) as the version.
#11
I have two requests:
1. A user can request a new password using any of his (or her) registered e-mail addresses.
2. An admin can add multiple e-mail addresses. (Until this is implemented, I am willing to modify the database directly.)
#12
I cant reproduce this bug.
Yeah i am not the maintainer of this module. Cant change this.
Feature Requests
Maybe later, but only confirmed e-mail addresses.
This feature is commited in http://github.com/webflo/multiple_email/commit/a3e197f8357c01956a3c00183...
Users need the "administer multiple emails" permission to do this. Download the latest version from github. Please test & review.
#13
I tried the new version. I like that admin can confirm the address with a checkbox. I got an error message: in multiple_email_add_page.inc on line 74:
dsm($form_state['values']['confirm']);I tried changing
dsm(the undefined function) todrupal_set_messageand it seemed to work, but the confirmation message looked odd:What I really want (as admin) is to add many e-mail addresses at once. As I said, I am willing to do this with SQL. I hope you can implement the other request.
Yes, that makes sense.
#14
Ohh yes, This a debug message from devel.module.
I am not sure what your mean. Do you want add multiple email addresses to one account or bulk import multiple email address to different accounts?
#15
I was thinking that I wanted to add many e-mail addresses to a single account. After thinking about it some more, I decided it was not a good idea after all.
#16
First of all, thank you so much for getting this started. This module is essential for a project I'm working on, so I'm going to be working on it quite a bit over the next few weeks. (I know, it took me a while to get started. Sorry.)
I've found a number of issues that probably need addressing. Correct me if I'm doing something wrong. I'm cataloging them here, just so that I have a list to go back to when I start working on them. If you'd rather me put the issues in your github project, I suppose I can, but it would really be best if we can get this project branched to d6 so we I can submit these issues individually. Until then, here goes:
When a new user is created, either by an administrator, or via the registration screen, the email address isn't entered into the multiple_email system.
When that happens, a big fat error shows up on the user's Multiple Emails edit screen:
Notice: Undefined variable: rows in multiple_email_addresses_page() (line 69 of /path/to/drupal/sites/all/modules/multiple_email/multiple_email_addresses_page.inc).
This is because the $addresses variable is empty.
When a user is deleted, the multiple_email table rows exist. They should be deleted.
Much of this can be fixed by expanding out the hook_user() function. I've started it, but it still needs work. For one thing, it should check to see if the user has "multiple emails" permission.
<?phpfunction multiple_email_user($op, &$edit, &$account, $category = NULL) {
switch ($op) {
case 'categories':
return array(array('name' => 'email-addresses', 'title' => 'E-Mail addresses', 'weight' => 100));
case 'form':
if ($category == 'email-addresses') {
$form = array();
return $form;
break;
}
case 'insert':
$eid = multiple_email_register_email($account->uid, $account->mail);
break;
}
}
?>
The email address field on the user/edit page is hidden for users who don't have "multiple emails" permission.
Administrators can access the "E-Mail addresses" tab for users who don't have "multiple emails" permission.
Speaking of which, the "multiple emails" permission should be renamed to something that contains a verb: "use multiple emails" for instance.
Gotta run. I'm at DrupalCon now, so webflo, if you're here, maybe we can say hi.
#17
As per your request, Josh Benner, attached is a big 'ol patch file run agains DRUPAL-5 of multiple_email. This incorporates the work that webflo and I have done porting this to Drupal 6.
Also attached is an additional .test file that I started. It's by no means complete, but it didn't appear on the patch file, so I guess you have to add it manually.
Thanks for getting the D6 branch on the books, so we can start filing issues against it.
#18
Hmm, you asked for a patch against HEAD, and I made it against DRUPAL-5. Don't know if there's any difference, but in any case, here's a patch against HEAD. The .test file is the same, though.
Shawn
#19
I have created the 6.x branch, and am flagging this issue as needs review. Please test the patch in 18 against 6.x-1.x-dev (which is actually still a 5.x copy of the module). I'll be doing the same, and we'll hopefully get this patch into the 6.x branch shortly.
#20
Dunno if it counts, since I'm the one that rolled the patch, but I did check out DRUPAL-6--1 and run the patch against it, (and added the .test file) and it does seem to work. Now, I gotta get webflo to do it too. I'm still getting one fail on that simpletest, but that's a bug we can work out once the 6.x version is fully loaded.
#21
I have applied the patch from 18 to the 6.x branch and committed with only very very minor changes. I also added the .test file as provided. The packaging system should update the 6.x-1.x-dev snapshot in a bit.
More testing/reviewing would be helpful!
#22
fixed
#23
Automatically closed -- issue fixed for 2 weeks with no activity.