The module works great, but some micro bugs remain.

When I use the option "Attempt to fetch results from a content search when finder results are empty" and search some word, correct results are showing with this error:

warning: Missing argument 6 for theme_finder_results(), called in /home/gaminru/public_html/sites/all/modules/finder/modules/finder_search/finder_search.module on line 69 and defined in /home/gaminru/public_html/sites/all/modules/finder/includes/finder.theme.inc on line 54.

When I use the pager option with "Attempt to fetch results...", double pager are showing (but both works).

When I use the option "Always redirect to the first result node" with "Attempt to fetch results..." and finder results are really empty, page is redirecting to "/node".

Comments

danielb’s picture

cheers I will sort that out

danielb’s picture

you know maybe it's just me but I never see a pager in search results, ever. Doesn't matter if it's through the search block or through finder's 'attempt to ...' mode, I never see any pagers, I get the first page of results and that's it.

danielb’s picture

I've made the improvements suggested in this issue, but I still can't see a pager, so I don't know about that bit, can you have a look and see if there are still two or what :/

Gyt’s picture

I still see two pagers if select 'Pager: 10' and 'attempt to...' mode. It happens when >10 results and search module results (on finder results page everything is OK). When I set 'Pager: 0' , I still see a pager on search module results page.

danielb’s picture

Search module results are forced to 10 per page, seems this is hardcoded into the pager queries the search module makes.

danielb’s picture

Gyt, are you saying when pager = 0, you only see a single pager ? And it still works properly with 10 per page? Perhaps I will just make pager = 0 in the code if it uses search finder.

Gyt’s picture

Status: Active » Fixed

That's fix a problem:

change "$pager = 10;" on line 69 finder_search.module to "$pager = 0;"

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.