1. navigate to a forum topic (node/xxxx)
2. Look at the breadcrumb

Expected behavior: the path to the forum containing the topic is displayed as the breadcrumb

Actual behavior: only one link ("Home") is displayed

CommentFileSizeAuthor
#6 menu_location_fix.patch537 bytesJaza
#4 menu-fix-breadcrumbs-bug46184.patch354 bytesWesley Tanaka

Comments

Wesley Tanaka’s picture

Wesley Tanaka commented
Component: forum.module » taxonomy.module

It appears that this might be a taxonomy problem, since none of the breadcrumb code in forum.module changed

Wesley Tanaka’s picture

Wesley Tanaka commented
Component: taxonomy.module » menu system

I tried reverting menu.inc back to revision 1.97, and the breadcrumb appeared properly.

Wesley Tanaka’s picture

Wesley Tanaka commented
Title: regression from 4.7.0 beta 3 to HEAD: forum nodes no longer have breadcrumb » regression in menu.inc rev 1.104: (forum) nodes no longer have breadcrumb
Wesley Tanaka’s picture

Wesley Tanaka commented
Title: regression in menu.inc rev 1.104: (forum) nodes no longer have breadcrumb » regression in menu.inc rev 1.104: (forum) nodes no longer display breadcrumb
Status: Active » Needs review
StatusFileSize
new menu-fix-breadcrumbs-bug46184.patch354 bytes

This patch reverts menu.inc back to its 1.103 state, which restores the breadcrumb display for me. I don't understand the 1.103->1.104 change, so I'll leave a proper fix up to someone more able to produce one.

Wesley Tanaka’s picture

Wesley Tanaka commented
Title: regression in menu.inc rev 1.104: (forum) nodes no longer display breadcrumb » (forum) nodes display no breadcrumb (regression: menu.inc 1.104)
Jaza’s picture

Jaza commented
Title: (forum) nodes display no breadcrumb (regression: menu.inc 1.104) » breadcrumb gone for pages that use menu_set_location()
Assigned: Unassigned » Jaza
StatusFileSize
new menu_location_fix.patch537 bytes

The problem here is that the menu_get_item() cache is not getting cleared when menu_set_active_item() runs. Attached patch fixes this problem.

This is similar to http://drupal.org/node/45854, which I thought was the last of this new caching problem. Hopefully the cache won't need to be cleared in any more places after this.

Jaza’s picture

Jaza commented

By the way, I changed the title of this issue because I found that the problem occurs in all pages that use menu_set_location(). Many other modules apart from forum have pages that use this, e.g. image.module (the gallery pages and the nodes themselves).

Wesley Tanaka’s picture

Wesley Tanaka commented

I applied http://drupal.org/files/issues/menu_location_fix.patch from http://drupal.org/node/46184#comment-69106 and it worked for me.

Jaza’s picture

Jaza commented
Status: Needs review » Reviewed & tested by the community
fax8’s picture

fax8 commented

I can confim this bug on 4.7 beta 4 .
this patch http://drupal.org/files/issues/menu_location_fix.patch solved the problem.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

I committed this patch. The cache bugs are getting ugly and it's not clear how this affects performance.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)