Closed (fixed)
Project:
Drupal core
Version:
5.x-dev
Component:
base system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
27 Jan 2006 at 01:55 UTC
Updated:
15 Nov 2008 at 16:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
markus_petrux commentedCould you please add the sort option to module_implements() ?
Comment #2
markus_petrux commentedComment #3
markus_petrux commentedI believe there's a bug in the patch. If $refresh is true, $sorted_list is not initialized.
Comment #4
markus_petrux commentedI hope you don't mind. I have re-rolled the patch with the following changes:
1) fixed the $sort_list issue.
2) implemented the $sort argument in module_implements() as well.
3) Revised usage of this new functionality for filter.module and user.module
4) Ditto for help.module, but included the changes in another issue that I believe cleans the help page a little too.
Please, review.
Comment #5
markus_petrux commentedComment #6
chx commentedComment #7
markus_petrux commentedDue to the replacement of www.drupal.org with drupal.org, the patch does not apply cleanly.
:-(
Comment #8
markus_petrux commentedJust want to propose a simple exercise. Have you tried to find something in admin/access ? Well, this patch would help you a little, sorting modules alphabetically.
Comment #9
chx commentedRerolled.
Comment #10
killes@www.drop.org commentedI've only partially apllied the patch, omitting most of the user output places. I think that sorting by weight woudl make more sense for example for filters. Setting to active to we can discuss this.
Comment #11
markus_petrux commentedhmmm... if there is a big list of filters, I believe it is easier, from the user point of view, to see the list alphabetically sorted. The order modules are loaded is not important to list available filters, IMO.
Comment #12
markus_petrux commented...this is the list of available filters. even, if this list is sorted by weight, the filters will be applied in the order the user has selected later.
I don't get why sorting by weight here is important. Could you please elaborate?
OTH, it's more user friendly to scroll the list if it is sorted alphabetically, I think.
Comment #13
markus_petrux commentedSo... anyone up to discuss this? :-)
How do you like to see the filters, ordered by weight or alphabetically?
Comment #14
moshe weitzman commentedI'll just add that themes do not currently consider weight at all now and although i see a ksort() in the selector form, it doesn;t appear to work right.
Comment #15
magico commentedWhat is the purpose of this? Is there any bug or is this a patch for a new feature (allow sort on tables)?
Comment #16
chx commentedComment #17
coreb commentedMoving out of the "x.y.z" queue to a real queue.
I can't figure out where this needs to go, so I'm guessing 5.x-dev. Change it if i'm wrong.
Comment #18
dave reid$sort parameter have been added to module_list and module_implements. Closing this issue.
Comment #19
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.