Since modules are now ordered by weight, the help page does not list modules in alphabetic order.

The patch fixes that. In addition, I introduced a small optimization in help_menu, using module_implements(). Hopefully that helps speed up menu generation time. I have also slightly changed the look of the admin/help page, so the help area displays part of the text that was in the content area (otherwise the "more help" link was alone).

Please, see attached patch.

Comments

markus_petrux’s picture

StatusFileSize
new4.24 KB

Sorry, forgot to attach the patch (the file attachment field is cleared when using preview).

chx’s picture

Markus, can't you reuse http://drupal.org/node/46617 ?

markus_petrux’s picture

Do you mean using the new parameter to get modules sorted? Oh yeah, I missed that issue.

When it gets in, I may update the patch here. Is that ok?

markus_petrux’s picture

StatusFileSize
new9.08 KB

I have made another version that breaks the list of modules into 4 columns, using the same CSS trick used for the handbook pages.

Please see attached screenshot. I may update the patch with it, if the idea worths.

markus_petrux’s picture

StatusFileSize
new4.73 KB

Patch re-rolled, with one dependency on another issue, it uses the module $sort argument implemented here:
http://drupal.org/node/46617

Please, review. (You can see how it looks in the gif attached to comment #4).

markus_petrux’s picture

Well, the $sort argument in module_list() has been finally applied to HEAD by this issue :-)

This is how the help page looks with this patch:
http://drupal.org/files/issues/help_page.gif

Summary of changes introduced:
1) Optimized using module_implements().
2) Modules sorted alphabetically.
3) Modules listed in 4 columns.
4) Moved some text to the "help" area of the page.
5) correct $output initialization.

Thoughts?

markus_petrux’s picture

It may not be critical, but is it acceptable to ship 4.7 with the help page ordering modules by weight? Not all modules implement help text, so it is not easy to find if is there anything there of your interest, specially when you have several contrib modules installed.

Is there anything wrong with the proposed patch?

markus_petrux’s picture

StatusFileSize
new5.06 KB

Forgot to add the CSS classes used to render the columns.

Please, consider this for 4.7. At least, the help page ought to list modules alphabetically ordered, IMHO.

markus_petrux’s picture

StatusFileSize
new5.73 KB

Maybe it helps to review it, posting a pre patched help.module?

Though you would have to add the following to the drupal.css file...

 /*
** help module
*/
.help-items-left {
  float: left;
  width: 22%;
  padding-right: 3%;
}
.help-items-right {
  float: left;
  width: 22%;
}
markus_petrux’s picture

Can anyone please tell me what did I do wrong here? It makes me feel strange. Is ordering modules in help page too bad? insignificant? All I try is help wherever I can... I'm thinking that you do not really want some kind of help. Is it that difficult to say no, this one is going to be delayed for 4.8... or keep this, remove that, whatever. ...and this is not the first time. You keep asking for community help, but there is something that doesn't seem to work correctly here.

I could undestand if this was a feature request, but it isn't. In 4.6, modules in help were ordered alphabetically. It is certainly not a critical issue, but someone spent sometime to provide a fix for something and even with an screenshot, or even the 130 lines of the full script to make it easy to test. Is it that difficult to press the follow up link?

Is this response meaning that you don't like what I do here? Oh well, maybe there are better things I can do elsewhere.

merlinofchaos’s picture

Hmm. I like the 4 column help list.

Stefan Nagtegaal’s picture

Nice catch here! Works as advertised...
Let's wait for another review and then set this RTBC, I am pretty sure this truly works and doesn't introduce any other errors..

Nice piece of code..

markus_petrux’s picture

Thanks for the comments, really appreciated.

nicklucas’s picture

Works like it should. Before applying the patch the Help Topics weren't listed alphabetically, and after applying it they are. Good work!

markus_petrux’s picture

Status: Needs review » Reviewed & tested by the community

Let's say this is RTC then.

Steven’s picture

I like the idea, but the code can be improved. The CSS means that the padding only gets applied between the first and second column, and not between any others. This can't be right. The code also refers to two columns though it outputs four.

I went ahead and updated the patch, and committed it. It's a simple but nice improvement.

Steven’s picture

Status: Reviewed & tested by the community » Fixed
Anonymous’s picture

Status: Fixed » Closed (fixed)