Posted by tobiasb on May 21, 2009 at 7:23pm
| Project: | User Comment |
| Version: | 6.x-2.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
the modul has many bugs, so I reviewed and solved this.
see the patch.
Comments
#1
#2
#3
Any chance you would consider backporting for Drupal 5.x? We really need a module like this.
#4
fix the module ffs :/ the current version doesn't works at all...
#5
The Patch is for 6 dev.
#6
can you paste fixed code without - + i dont have command line and stuff :/
#7
ok,
#8
ok I'm gonna try it now,
#9
On profile edit page users don't see 'Skip blog approvals' even this users have ability to create blog entry.
I think it’s because blog module use 'create blog entries' permission instead 'create blog content' and verification in usercomment.module at line 230 is never pass:
if (user_access('create '. $node->type .' content', $account)) {I was change this line to:
if (user_access('create '. $node->type .' content', $account) || user_access('create '. $node->type .' entries', $account)) {Its work for me, but I'm not sure that is the best solution.
#10
First, thanks to Razorraser for this very helpful module!
Also, thanks to dicreat for the patch - it works for me too!
#11
Would be great to have a 5.x version
#12
yea the patch works perfectly, the module should be updated with this
#13
I just noticed that common registered users cannot post comments in forum without approval :(
#14
you need to check permissions.. you need to enable the permission who allows all users to post without approval,
#15
vertazzar, I have no such options in user profile on my site, except user #1
can anyone patch this like dicreat in #9 ?
#16
its here :
http://pokit.etf.ba/upload/?pokitf0b1d5879866f2c2eba77f39993d1184.png
www.yourwebsite.com/admin/user/permissions/2
#17
when I select this last checkbox for any role, even for administrator with all permissions I constantly get this message:
'An illegal choice has been detected. Please contact the site administrator.'
But thanks for taking attention!
#18
sandino, see this fix for your error http://drupal.org/node/543276 .. i had it too, let me know how it works out
#19
Ok, a new version. Now it is works with forum/blog Module and I remove ' from the permission. Please use the update.php script.
1 patch for the beta,
1 patch for the dev version
and a patched version.
#20
thank you!
#21
Razorraser, can you upload patched beta-version. And what is different dev from beta?
#22
You can use http://drupal.org/files/issues/usercomment-6.x-dev_0.zip.
You are right, there is no different.
but the updated date
dev:
Last updated: January 31, 2009 - 01:22
beta:
Last updated: May 15, 2009 - 17:21
and this
usercomment.module /* $Id: usercomment.module,v 1.5.2.6 2009/04/22 14:16:22 gwen Exp $ */
is in dev and beta. is this magic?
#23
Another small question - is it possible to hide comment title? May it be a feature of next version of user comment?
#24
Not in the module. copy comment.tpl.php from modules/comment/comment.tpl.php and remove there the title.
#25
Hi, this module is great and EXACTLY what we need. But for 5.x please too!!!
#26
Drupal 5 is here http://drupal.org/node/151291
#27
I give permission to node owner to delete comments and it is works, but the site admin(uid 1) don't have a permission to delete the comment.
I receive this error message:
Access denied
You are not authorized to access this page.
Edit:
After checking the module code it is clear now. The function usercomment_access_check() return FALSE for admin because he have 'administer comments' permission and can use the regular delete link
#28
tobiasb,
Due to the fact that the module developer doesn't appear to have any love for this module, and you have done such great work here, have you considered appealing to become the maintainer?
The process is simple, and documented here: http://drupal.org/node/251466
Let me know if you have any thoughts or need any help.
Cheers,
Deciphered.
#29
Subscribing
#30
I'm using this module for long time, and it is really useful for community-type websites
#31
I did some more rewrite. I used hook_menu_alter to change the access callback for comment/delete. This way we don't have the additional path usercomment/delete. I also changed usercomment/approve to comment/approve.
#32
I fixed another issue. Just removed the skip author's approval queue permisson and used comment modules post without approval permission instead.
#33
Hi!
Great module!
If you are really in rewrite process, there is another tiny thing; in the Readme.txt line 21 you point to the admin/user/access path. But there is no such path in Drupal. This should perhaps be admin/user/permissions.
Sorry for bothering, but - YES, I READ THE F***ING README! ;-)
#34
Great module, and thanks for the rewrite!
#35
#32 works for me
#36
#32 also worked for me, but I need some control over the output. Comment Approval (class = ".usercomment") is being dropped right in the middle of my node. I've attached a screen shot pointing to what I am talking about. If possible I would like to move the comment approval section to it's own section between the article and the post new comment section. Any feed back would be greatly helpful.
#37
So here is a follow up to my first posts. I have 4 problems with #32's patch.
#1 It breaks ajax comments.
#2-#4 Are shown in the attached Image
#2 Pending comments are listed twice
#3 Output of usercomments module is in the middle of the main article
#4 Published comment counting is off due to unpublished comments being counted.
#38
Sorry for the super long lag getting to this, but I just incorporated patch 31 into the 6.x-2.x branch. I chose not to apply patch 32 b/c the extra 'skip author's approval queue' permission allows for a more flexible set up (e.g. you can let users post comments to some node types like forums that you may not want users to administer and let the author decide for other node types like blog).
Thanks to everyone for their hard work!
@animelion
Re: comment 36: I added a setting to the admin page where you can set the weight of the approval form to move it below node content.
Re: comment 37: The module seems to work fine with a vanilla installation so I created a new issue http://drupal.org/node/703914 to deal with these issues since I think they're specific to other modules/themes. Please enter all comments regarding those issues there.
#39
#40
Automatically closed -- issue fixed for 2 weeks with no activity.