Comments

tobiasb’s picture

StatusFileSize
new30.1 KB
tobiasb’s picture

Category: task » bug
StatusFileSize
new30.01 KB
ianchan’s picture

Any chance you would consider backporting for Drupal 5.x? We really need a module like this.

vertazzar’s picture

fix the module ffs :/ the current version doesn't works at all...

tobiasb’s picture

Version: 6.x-1.0-beta1 » 6.x-1.x-dev

The Patch is for 6 dev.

vertazzar’s picture

can you paste fixed code without - + i dont have command line and stuff :/

tobiasb’s picture

StatusFileSize
new12.64 KB

ok,

vertazzar’s picture

ok I'm gonna try it now,

dicreat’s picture

On profile edit page users don't see 'Skip blog approvals' even this users have ability to create blog entry.
I think it’s because blog module use 'create blog entries' permission instead 'create blog content' and verification in usercomment.module at line 230 is never pass:
if (user_access('create '. $node->type .' content', $account)) {

I was change this line to:
if (user_access('create '. $node->type .' content', $account) || user_access('create '. $node->type .' entries', $account)) {
Its work for me, but I'm not sure that is the best solution.

sandino’s picture

First, thanks to Razorraser for this very helpful module!

Also, thanks to dicreat for the patch - it works for me too!

plan9’s picture

Would be great to have a 5.x version

vertazzar’s picture

yea the patch works perfectly, the module should be updated with this

sandino’s picture

I just noticed that common registered users cannot post comments in forum without approval :(

vertazzar’s picture

you need to check permissions.. you need to enable the permission who allows all users to post without approval,

sandino’s picture

vertazzar, I have no such options in user profile on my site, except user #1

can anyone patch this like dicreat in #9 ?

sandino’s picture

when I select this last checkbox for any role, even for administrator with all permissions I constantly get this message:

'An illegal choice has been detected. Please contact the site administrator.'

But thanks for taking attention!

abaddon’s picture

sandino, see this fix for your error http://drupal.org/node/543276 .. i had it too, let me know how it works out

tobiasb’s picture

StatusFileSize
new12.64 KB
new31.55 KB
new31.55 KB

Ok, a new version. Now it is works with forum/blog Module and I remove ' from the permission. Please use the update.php script.

1 patch for the beta,
1 patch for the dev version
and a patched version.

vertazzar’s picture

thank you!

SLUH’s picture

Razorraser, can you upload patched beta-version. And what is different dev from beta?

tobiasb’s picture

You can use http://drupal.org/files/issues/usercomment-6.x-dev_0.zip.

You are right, there is no different.

but the updated date

dev:
Last updated: January 31, 2009 - 01:22
beta:
Last updated: May 15, 2009 - 17:21

and this
usercomment.module /* $Id: usercomment.module,v 1.5.2.6 2009/04/22 14:16:22 gwen Exp $ */

is in dev and beta. is this magic?

SLUH’s picture

Another small question - is it possible to hide comment title? May it be a feature of next version of user comment?

tobiasb’s picture

Not in the module. copy comment.tpl.php from modules/comment/comment.tpl.php and remove there the title.

Brumisek’s picture

Hi, this module is great and EXACTLY what we need. But for 5.x please too!!!

tobiasb’s picture

Igal’s picture

I give permission to node owner to delete comments and it is works, but the site admin(uid 1) don't have a permission to delete the comment.
I receive this error message:
Access denied
You are not authorized to access this page.

Edit:
After checking the module code it is clear now. The function usercomment_access_check() return FALSE for admin because he have 'administer comments' permission and can use the regular delete link

deciphered’s picture

tobiasb,

Due to the fact that the module developer doesn't appear to have any love for this module, and you have done such great work here, have you considered appealing to become the maintainer?

The process is simple, and documented here: http://drupal.org/node/251466

Let me know if you have any thoughts or need any help.

Cheers,
Deciphered.

resynthesize’s picture

Subscribing

vertazzar’s picture

I'm using this module for long time, and it is really useful for community-type websites

DrakeRemory’s picture

StatusFileSize
new17.67 KB

I did some more rewrite. I used hook_menu_alter to change the access callback for comment/delete. This way we don't have the additional path usercomment/delete. I also changed usercomment/approve to comment/approve.

DrakeRemory’s picture

StatusFileSize
new12.46 KB

I fixed another issue. Just removed the skip author's approval queue permisson and used comment modules post without approval permission instead.

xqbzzr’s picture

Hi!
Great module!
If you are really in rewrite process, there is another tiny thing; in the Readme.txt line 21 you point to the admin/user/access path. But there is no such path in Drupal. This should perhaps be admin/user/permissions.
Sorry for bothering, but - YES, I READ THE F***ING README! ;-)

minus’s picture

Great module, and thanks for the rewrite!

bryancasler’s picture

#32 works for me

bryancasler’s picture

StatusFileSize
new874.27 KB
new874.27 KB
new874.27 KB

#32 also worked for me, but I need some control over the output. Comment Approval (class = ".usercomment") is being dropped right in the middle of my node. I've attached a screen shot pointing to what I am talking about. If possible I would like to move the comment approval section to it's own section between the article and the post new comment section. Any feed back would be greatly helpful.

bryancasler’s picture

Title: Rewrite the module » 4 Problems
StatusFileSize
new44.82 KB

So here is a follow up to my first posts. I have 4 problems with #32's patch.

#1 It breaks ajax comments.

#2-#4 Are shown in the attached Image

#2 Pending comments are listed twice
#3 Output of usercomments module is in the middle of the main article
#4 Published comment counting is off due to unpublished comments being counted.

gwen’s picture

Title: 4 Problems » Rewrite the module
Version: 6.x-1.x-dev » 6.x-2.x-dev

Sorry for the super long lag getting to this, but I just incorporated patch 31 into the 6.x-2.x branch. I chose not to apply patch 32 b/c the extra 'skip author's approval queue' permission allows for a more flexible set up (e.g. you can let users post comments to some node types like forums that you may not want users to administer and let the author decide for other node types like blog).

Thanks to everyone for their hard work!

@animelion
Re: comment 36: I added a setting to the admin page where you can set the weight of the approval form to move it below node content.
Re: comment 37: The module seems to work fine with a vanilla installation so I created a new issue http://drupal.org/node/703914 to deal with these issues since I think they're specific to other modules/themes. Please enter all comments regarding those issues there.

gwen’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.