This issue was originally a comment entered by antimelionin another issue: http://drupal.org/node/469478#comment-2452568.
So here is a follow up to my first posts. I have 4 problems with #32's patch.
#1 It breaks ajax comments.
#2-#4 Are shown in the attached Image
#2 Pending comments are listed twice
#3 Output of usercomments module is in the middle of the main article
#4 Published comment counting is off due to unpublished comments being counted.
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 703914.patch | 1.47 KB | rschwab |
| #4 | content-owner-count.jpg | 38.39 KB | rschwab |
| #4 | non-owner-count.jpg | 23.04 KB | rschwab |
| #4 | user-1-count.jpg | 51.03 KB | rschwab |
| 3problems.gif | 44.82 KB | gwen |
Comments
Comment #1
gwen commented#1 will take a look
#2 & #4 I think this is a theme issue since garland doesn't show comment number. Can you let me know what theme you're using or if you're using custom code, paste in code used in comment.tpl.php and/or custom changes made using phptemplate_preprocess_comment()?
#3 i added a setting for weight of the approval form to the admin page that should fix.
Comment #2
bryancasler commentedAdaptive Theme http://drupal.org/project/adaptivetheme
I am using adaptive theme v2.0rc1 http://drupal.org/node/653162
There is a new release however v2.0 http://drupal.org/node/672892
I will go ahead and upgrade my user comment module ASAP and get back to this thread.
Comment #3
bryancasler commentedIn response to problem #4
My comment.tpl.php uses
<span class="comment-id"><?php print '#'. $id; ?></span>Comment #4
rschwab commentedThank you for your bug report, animelion!
On #1, are you referring to the Ajax Comments module? I'm going to assume so and look into that next in a different issue.
#4 actually seems to be working as expected. A user with approve permissions see the total including unapproved comments, while others see the total of only approved comments (see attached screens).
#3 was fixed by gwen so that just leaves #2. As shown in user-1-count.jpg, the messages and comments are printed twice. I'll try to get that fixed here.
Comment #5
rschwab commentedThis patch prevents the usercomment approval form being printed when the user has the "administer comments" permission. Comment module takes care of this workflow for these users already, so we should be able to safely ignore this situation. Committing to 2.x-dev.
Ajax comments will be a different issue.