Hi

I got into it and added all the things to make have state descriptions work and show up. I am not a guru but I think my stuff is pretty solid and I let the other code make all the decisions about applicability etc.

The patch is attached.

Hope its okay.

Mark

CommentFileSizeAuthor
#2 wf_desc.png7.44 KBjvandyk
workflow_patch_add_state_descriptions.patch3.05 KBmarknewlyn

Comments

marknewlyn’s picture

marknewlyn commented

Sorry about this - I also added a column to the workflow states table:

ALTER TABLE workflow_states ADD COLUMN description LONGTEXT DEFAULT NULL;

Mark

jvandyk’s picture

jvandyk commented
StatusFileSize
new wf_desc.png7.44 KB

I'm not sure why you wouldn't just title your state, e.g.,

in review: we are watigin for someone to review this

instead of

in review

Others, weigh in please. The proposed patch changes the workflow section of the node form to look like this: screenshot.

jvandyk’s picture

jvandyk commented
Title: Patch to add state descriptions as in <a href="?q=node/46965/view">46965</a> » Patch to add state descriptions as in #46965

Grr, ignore the link to the screenshot and just see the attachment.

marknewlyn’s picture

marknewlyn commented

Hi

If you have a relatively complex workflow that can trigger multiple actions in a single state change I think its good to have the descriptions go with the states. I am using the workflow to allow 3 groups of users to interact and automatically create a set of 3 different nodes so I just want things to be as clear as possible. My beta-testers asked for it explicitly.

Just my 2-cents worth.

Mark

jvandyk’s picture

jvandyk commented

In that case, wouldn't it be easier to use radio buttons instead of a select box with a redundant description block?

marknewlyn’s picture

marknewlyn commented

Good point, that would be more natural and look better. That would be a definite improvement
on my suggestion.

Mark

mfredrickson’s picture

mfredrickson commented

I've moved workflow onto the taxonomy system, where states are terms. Since terms can have descriptions, I think this fix will help. Displaying the text will just be a UI trick.

Can you review:

http://drupal.org/node/49537

and let me know if it will help your problem?

jvandyk’s picture

jvandyk commented

I have a revised version of this patch that changes the workflow state widget from a dropdown to radios.

marknewlyn’s picture

marknewlyn commented

Hi

I'd be keen to try it out if you don't mind posting it or sending it to me.

Thanks,

Mark

jvandyk’s picture

jvandyk commented
Assigned: Unassigned » jvandyk

The patch to use radios is now committed. I think radios are more intuitive. Leaving this open in case people still feel we need descriptions for states.

marknewlyn’s picture

marknewlyn commented

Hi

I am gonna stick with having the descriptions because my site is for non-technical volunteers and it is crucial that we minimise any difficulty or confusion. I attached a screen shot to the other discussion about collapsed or not as a default field setting:

node/49850

In our experience you really have to pander to volunteers and we hope to get a large number of people who
are unlikely to have any experience with interactive sites involved. I haven't put the radio buttons in yet but I'll see how I can put it all together.

I like the views module and I see that views support has been added so I'll probably migrate to a new workflow version very soon (i.e. this weekend).

Mark

mfredrickson’s picture

mfredrickson commented
Status: Needs review » Postponed

I'm going to lump this request into "we want labels on transitions" collection and postpone for 5.0+

moshe weitzman’s picture

moshe weitzman commented
Status: Postponed » Active
Bastlynn’s picture

Bastlynn commented
Status: Active » Closed (won't fix)

Hi,

This ticket was last updated over 4 years ago, and hasn't seen additional work since then. Based on that, and that development is now progressing on Drupal 7, I'm going to go ahead and close this one out. If you would still like to see this feature, please post a request for Drupal 7, then we can work on the Drupal 6 version.

- Bastlynn