Hello
I noticed some changes and missed features when I changed from 6.x-1.6 to 6.x-2.0-rc2.
First, when blockquote'Display link information?' is enbaled, I have both drupal (french) and weblinks (english) generated strings. Example, I have both lines:
Soumis par amine00 le lun, 05/25/2009 - 20:39
created: 25 May 2009 by amine00
Shouldn't only one of these lines appears?
If I disable 'Display link information?', the first line still appears. I expected to hide any information.
The second problem is that I want to hide the url and keep only the link title, but there is not a 'hide url' option as in previous version.
And last, it would be nice if also you could provide an option to control roles that can view such lines:
Clicked 1 times. Last clicked 05/25/2009 - 20:40.
Comments
Comment #1
nancydruIt looks like maybe you have the "submitted by" theme option enabled for Web Links as well as.
Please also look at #457860: Remove "Created by...". Perhaps you would like to add your own comments to that potential change. In that issue, I want to completely remove this code and rely on the core theme setting to turn the display on and off and the Submitted By module if you want to customize the format of that information.
I should have the "view click count" permission in place momentarily.
Comment #2
nancydruThe "view click count" permission has now been committed to 6.x-2.x-dev.
Comment #3
akadimi commentedI Hope in final release users wouldn't have to deactivate both theme option an Weblinks option to hide author information.
Other questions:
1- What about the 'Hide URL' option?
2- Why when the option 'Link description display' is set to 'no description' I still get the link description?
Comment #4
nancydru- This is one of the reasons why that other issue was created. Plus, we are trying to move to more of a core-controlled environment, which is the main thrust of version 6.x-2.x. Eventually, we want to get to where Web Links is actually two primary pieces: an API and a wrapper that does what you see today.
1) I'm still thinking about how to do that. One problem is that the same theme function does both the main links page and the node display page, so hiding it on the links page without hiding it on the node page is not trivial, but I have some ideas.
2) I discovered that problem and have it fixed in my code already; I'm just not sure I have it fixed correctly (again the main page/node page issue).
Comment #5
nancydru#2 is now fixed.
Comment #6
akadimi commentedBTW, I just seen that when 'Show the node title' is disabled, a node title is being displayed. And when it's disabled, the title is being displayed twice, I searched the theme settings but there's no option to hide the title.
Comment #7
rmiddle commentedSome themes hard code the title field. We we add the title field the right way. You get two copies. When we don't add the title at all you are getting one listed. You would need to talk to your theme maintainer about this.
Thanks
Robert
Comment #8
nancydruThe settings page is reorganized somewhat, but there is now a setting above "Link displays as" that now does what you wanted with the "Hide URL."
Comment #9
akadimi commentedBut it worked fine with the 6.x-1.6.
See the screenshot, I only have a list of
<title + URL>, and it seems for me that the titles are generated by Weblinks, and I love how it is done through a<ul><li>tags.Also, in 6.x-2.0, the title generated by Weblinks is tagged with a
<h2 class="title">tag, which could have an unwanted effect: Changes to node title style affects the link title style.Comment #10
akadimi commentedNancy, I'll try that. What do you think about the title issue?
Comment #11
nancydru6.x-2.x is a significant change moving the module to more core-standard handling and theming. An advantage to the theming support is to allow you the freedom to make it look the way you want. Many users asked for this type of change. In order to accomplish it, some old settings changed and some went away entirely. It appears there are something like 225 people using version 2, and apparently liking what they see.
Your last post didn't format well, so it is hard for me to understand. There is a situation with titling because some themes, like Garland, expect the module to create the title, where other themes make the titles themselves. That's why we now need the "Show the node title" setting. (See #419334: Duplicated title.)
Comment #12
akadimi commentedI fixed my last post (#9) could you please reread it.
I'll try to forget the v1 behavior, because I also like the v2 much more, I just want to success on displaying one flat list of all links with no description, no categories, nothing but the title and maybe the URL, and one line per link.
FYI, Link description is still displayed even if I choose to disable it.
I'd like to thank you for your effort.
Comment #13
nancydruThe -dev version only rolls up at Noon and Midnight GMT, so it will be a few hours before these changes are reflected in the code unless you use CVS checkout.
Comment #14
nancydruYou might want to consider changing "weblinks-link.tpl.php" to something along the lines of:
Comment #15
nancydruIncluded in 6.x-2.0-rc3.