Hello,
We have a subscriber's list over a 1000 emails. Now, it's quite troublesome to look for a specific email address: you have to guess which page it will be in.
It would be nice to be able to sort emails, seach the list for emails like "we*" or whatever, etc...
Also, why not add a field with the date the person subscribed? Sorting by date would allow us to see who just subscribed.
Anothing thing: people sign in the simplenews block, but then do not confirm (didn't receive confirmation email, changed their minds, etc..). Their mails is in the data base, but not subscribed to any list. Right now, it's possible to see the list of people subscribed to a particular newsletter. It shouldn't be too difficult to have the list of people who are not subscribed to any. (related question: what happens when a person cancels a subscription: is their email deleted from the database altogether?).
thank you.
B.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | subscription-management_2.patch | 22.14 KB | sutharsan |
| #17 | subscription-management_1.patch | 19.79 KB | sutharsan |
| #15 | subscription-management.patch | 20.84 KB | sutharsan |
| #11 | simplenews.module_4.patch | 3.71 KB | mgifford |
| #9 | simplenews_14.patch | 3.7 KB | mgifford |
Comments
Comment #1
DriesK commentedThey're all good questions. I'm planning to implement some of them, others have a reason. I don't have time right now to go into details. Right now, I'm quickly answering some issues in the list, just to let you know that I'm still alive :-)
I'm working very hard to get my PhD thesis finished in time. I expect to be able to start coding again in April, but there'll be a lot to catch up with so it may take some time to address everything...
Until then, I'll only fix critical bugs, and make sure that simplenews HEAD keeps up with Drupal HEAD (a simplenews 4.7 branch will be created right after the release of Drupal 4.7).
Comment #2
beginner commentedI urgently needed the ability to easily locate some emails within a list of over a 1000 for version 4.6.
I attach a small diff, which is a quick hack, for those who might want it.
This doesn't apply for HEAD.
I leave the issue version as cvs, though. Another patch would need to be worked out for HEAD.
Comment #3
beginner commentedthe same but remembers selection through session.
(I didn't explain clearly above: the patch allows you to list all mails like "hotmail.com" for example. Useful to shorten the list to a single email, for example).
Comment #4
beginner commentedHere is a patch for cvs.
as above, it add a simple 'search emails like' textfield to the subscription filter.
This is essential for us and others who have 1000s of subscribers to one newsletter.
Comment #5
beginner commentedA better patch to handle paging.
Comment #6
DriesK commentedthanks! I'm on holiday now, I'll take a closer look next week.
Comment #7
thepanz commentedHi, I try this patch on latest module version and it's working fine. I'm also tring to merge this patch with my one (about anonym user-name while subscripting) for searching also usernames.
Bye
Comment #8
sachbearbeiter commentedhello
it would be great to make the subscriber list more operational:
a) sort for username, e-mail-adress etc.
b) checkboxes to apply possible changes to more then one subscriber (delete, inactivate etc.)
c) search
thanks and greetings
sb
Comment #9
mgiffordI had 100 or so emails to remove from a list. Thought it was worth while porting this patch over to the 5.0 code.
It works for me, but could use more review. Would really hope that it could get merged into the code though as there really needs to be a better way to remove emails from this program. This works well!
Mike
Comment #10
beginner commentedThanks mgifford. Your patch is inverted.
See also this: http://drupal.org/patch/submit
The best is to patch against a cvs checkout.
Comment #11
mgiffordSome days are longer than others.....
Here's a new patch done against the CVS (and should be going the right direction even).
Mike
Comment #12
beginner commentedThe patch looks good and improves slightly on my earlier patch.
It's probably good to go.
Unfortunately, the module does not seem to be well maintained, and even if properly reviewed, I doubt someone would commit it (a patch has been up for review for over a year, now).
Therefore, I'll take a closer look when I'm actually ready to upgrade to D5.
Thanks mgifford for pushing the patch ahead :)
Comment #13
sutharsan commentedThings might be better than they seem. Agree the maintenance of the module has been low for sometime, but things are moving again for a month or two.
Currently I am working to improve the subscription maintenance to aid the maintenance of large amounts of subscribers. I want to include the functionality of this patch.
Comment #14
beginner commentedOh! I just noticed you have commit rights!
Thank your for your contributions to the module :D
Comment #15
sutharsan commentedI have included the email search functionality in this change of the subscription admin. The intent is to make it easier to maintain large subscription lists. It is also the solution for issues 82050 and 67551.
The code for subscription admin is completely changed and now based on the Administer Content page. It allows for operations on multiple subscriptions by using a check box for each subscriber.
* Operations: acivate, deactivate, delete
* Filter options: subscribed to, email address
A new file simplenews.css is included and required for layout of the subscription filters.
Comment #16
mgiffordIn applying your patch this one didn't stick. There's also an error elsewhere in the code as the form is producing this error -
[Thu Apr 19 19:23:33 2007] [error] [client 69.156.51.73] PHP Fatal error: Cannot unset string offsets in /home/dm_50/includes/form.inc on line 319
simplenews.module.rej
***************
*** 407,413 ****
$node->simplenews_tid = $tid ? $tid[0] : 0;
$s_status = ($node->send == 1 && user_access('send newsletter')) ? 1 : 0;
db_query("UPDATE {simplenews_newsletters} SET tid = %d, s_status = %d, s_format = '%s', priority = %d, receipt = %d
- WHERE nid = %d", $node->simplenews_tid, $s_status, $node->s_format, $node->priority, $node->receipt, $node->nid);
}
/**
--- 400,406 ----
$node->simplenews_tid = $tid ? $tid[0] : 0;
$s_status = ($node->send == 1 && user_access('send newsletter')) ? 1 : 0;
db_query("UPDATE {simplenews_newsletters} SET tid = %d, s_status = %d, s_format = '%s', priority = %d, receipt = %d
+ WHERE nid = %d", $node->simplenews_tid, $s_status, $node->s_format, $node->priority, $node->receipt, $node->nid);
}
/**
Comment #17
sutharsan commentedThe patch was made against the HEAD at that time. Here is a new patch against the current HEAD 1.57 version.
Comment #18
sutharsan commentedTable sorting added to further improve the handling of large amounts of subscribers.
Comment #19
mgiffordWorks fine for me!
Comment #20
sutharsan commentedPatch committed to HEAD and 5.x-1.x-dev.
Comment #21
(not verified) commentedComment #22
beginner commentedI just upgraded from 5.x-1.1 to 5.x-1.x-dev because I wanted this feature, but it doesn't seem to work.
At this page: /admin/content/newsletters/users
with 5.x-1.1 I have the whole list of subscribers.
with today's 5.x-1.x-dev, I have nothing: a themed page with an empty content, i.e. not even the list of subscribers. I went to the modules pages to save, in order to clear the menu cache, but still nothing.
Comment #23
thollowood commentedI have never used a patch before - and I need a patch for simplenews admin - in order to edit my subscriptions more easily. I have located "subscription-management_2.patch", but have no way of knowing if it will work with my site (drupal 4.7) and absolutely no idea how to go about installing it if it will work. Could anyone help me out please?
Just when I think I am getting the hang of something...
Comment #24
sutharsan commented@ beginner: is this problem persistent?
@thollowood: Please do not re-use an issue just because it is related. Please open a new issue if you need support. You find information on patches in: http://drupal.org/patch
Comment #25
beginner commentedI don't know. I had to revert the earlier install, because the feature was missing. It's working on my site, now, but only because I have applied one of my earlier patches posted above.
I don't have time to test, now.
If you are absolutely certain that the feature works at least in D6, then you can close this issue. I'll give you a shout when I upgrade to D6 if it still doesn't work. :)
Comment #26
beginner commentedComment #27
sutharsan commentedI am sure that it works. It is in the module almost a year now and had no (other) issues with it. It is also present in D6.
I close the issue, but feel free to create an issue of you (still) have problems with this functionality.
Comment #28
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.