There is a misspelling (weill) in the string 'If this option is selected, the rankings weill be displayed when the node is viewed.'
There is a misspelling (ben) in the string 'If this is selected, the number of times the link has ben clicked will be shown.'

There is an error in the string 'If this is selected, the number of times the link has been clicked will be shown in the site short date format (\"%fmt\").' In my eyes it must have to do with the last date and not the number of times.

Is it correct that the last dot in 'No vocabularies were used, so these links will be marked as \"%noclass.\" is before the '\"'?

On page ?q=admin/content/weblinks the title 'Web Links Overview' is not translatable.

I didn't check it so far, so I have to ask: if links are checked for validity, is there a check for the drupal_http_request_fails variable first? In other words: before the link will be checked there must be a check for the http status first, otherwise the result will be unwanted!

I hope it is not too much for one issue...

I also want to let you know that I have a german translation for 2.0, but it needs to be modified after this issue due to necessary string changes.

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Active » Fixed

'No vocabularies were used...' - yes, proper English includes the final punctuation inside the quotation marks.

"Web Links Overview" is a menu title, therefore it should be automatically translated; one does not include menu titles in t(). Are we doing something to mess that up?

'drupal_http_request_fails variable': "system_requirements" should be checking this; see http://api.drupal.org/api/function/system_requirements/6.

I committed the other changes. Thanks.

FrankT’s picture

FrankT commented
Version: 6.x-2.0-rc2 » 6.x-2.x-dev

With the latest dev I found the following string with a misspelling: 'This option detremines how the link's title will be shown in the rankings page.' (detremins)

I'm not a native english speaking person, but \"%noclass.\" looks strange to me whereas \"%noclass\". does not. This is just to aviod a possible misunderstanding, you may decide.

With 'Web Links Overview': I'm not a progammer, and so I'm sorry I can't help you: the only thing I can say is that although I imported a complete po file, it is not translated.

FrankT’s picture

FrankT commented
Status: Fixed » Active
nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Let's try this:

Go to line 142, in function _weblinks_get_menu_title()
It currently reads: return db_result(db_query("SELECT link_title FROM {menu_links} WHERE link_path = 'weblinks'"));

Let's wrap that with a t().
return t(db_result(db_query("SELECT link_title FROM {menu_links} WHERE link_path = 'weblinks'")));

This is not entirely correct coding, but I bet it works. Please let me know.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I committed these changes to 6.x-2.x-dev.

rmiddle’s picture

rmiddle commented

Wouldn't that break translation if anyone went in and renamed the link_title?

Thanks
Robert

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I don't think so. I think what I'm doing there actually restores translation that was bypassed.

FrankT’s picture

FrankT commented

Applying the dev of Jun 01 I found the title still as 'Web Links Overview'. But I also found out (sorry for the late understanding) that the menu item itself was 'Web Links Overview', too.

Changing the menu item manually also lead to a title with the same name. So the question seems to be why the menu item wasn't translated by the po file. I guess this is not an issue of web links so I suggest to closed this issue as fixed.

For finishing my translation I should have a hint on the meaning of 'Dead by: %comment', which I cannot find in the user interface so far.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

'Dead by:' refers to having a link marked as no longer working. That is in the LinksDB conversion code, so I'm not sure how critical it is, although that text is appended to the link body.

The menu title is still an issue IMHO. There is some code to work around a "bug" in the menu code (there is a core issue open on it), which reads the menu_links table directly, so the title was not being translated. I committed a change that I had hoped would cause it to be translated, but according to your report it is not.

I am also about to commit a small change to the Pralexa module, and it has some string changes.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Please try this for me:
Line 122 is function weblinks_init() {
change it to function _weblinks_init() { and clear your cache, then see if the menu item translates.

Otherwise, the translation template is up-to-date.

FrankT’s picture

FrankT commented

I thought it would be a good idea to renamed the menu entry back into 'Web Links Overview' first. To my surprise saving the menu entry did not change the way the menu entry is displayed, in other words it is still translated.

I also cleared the cache, then, but it didn't "help", the menu entry is still translated.

So I did not apply the changes you mentioned in #10.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

The problem here is that core (see #184955) doesn't behave the way people might think. Once a menu item has been "customized" (including adding weight), it is essentially frozen in its settings. This is particularly problematic when an item is moved to another menu (such as "Primary"). That's the issue (which has come up) I was trying to solve. We may be in a "lesser of two evils" situation here.

In actuality, clearing the cache is not the correct way to get the menu refreshed. If you have Devel, you should use "Rebuild menus."

I wish I knew how to set up translation on my site so I could do some testing.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Active » Postponed (maintainer needs more info)

Should this hold up the 6.x-2.0 official release?

FrankT’s picture

FrankT commented

Hi Nancy, I don't mind saving this for later and releasing 2.0.

d_k_n’s picture

d_k_n commented
Version: 6.x-2.x-dev » 6.x-2.0-rc3
Component: User interface » Views
Assigned: Unassigned » d_k_n
Category: bug » support

Hi,

i didnt found "show/not show link information" on settings page, but want
to disable this. In all files, in other settings or in db i searched theres this
not i can disable.
So...where i can figure this out ?

Best Regards.

P.s.:Sorry for my bad english

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

@d_k_n: #457860: Remove "Created by..." removed this setting. You now enable/disable the "submitted by" line through the core theme settings (admin >> site building >> themes >> configure). You may additionally change the way the "submitted by" line looks with the Submitted By module.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Assigned: d_k_n » Unassigned
nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

@rastatt@drupal.org: can you give me some pointers on how to set my site up for translation?

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Postponed (maintainer needs more info) » Fixed

I guess #483764: Remove admin page took care of this issue.

BTW, the next release has lots of string changes...

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Fixed » Closed (fixed)