App broken after enabling friends blocks

georgedamonkey - May 29, 2009 - 14:46
Project:Drupal for Facebook
Version:6.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Dave Cohen
Status:needs work
Description

I tried enabling the blocks for Facebook friends who have authorized the current app - and - Invite Facebook friends to install the current app

As soon as I clicked save, I get this error on the screen:

Facebook API exception Parser error: unexpected ')' at position 92..
#0 /var/clients/client0/web2/web/sites/all/modules/fb/facebook-platform/php/facebookapi_php5_restlib.php(834): FacebookRestClient->call_method('facebook.fql.qu...', Array)
#1 /var/clients/client0/web2/web/sites/all/modules/fb/contrib/fb_friend.module(122): FacebookRestClient->fql_query('SELECT uid FROM...')
#2 [internal function]: fb_friend_block('view', 'fb_friend_invit...')
#3 /var/clients/client0/web2/web/includes/module.inc(450): call_user_func_array('fb_friend_block', Array)
#4 /var/clients/client0/web2/web/modules/block/block.module(473): module_invoke('fb_friend', 'block', 'view', 'fb_friend_invit...')
#5 /var/clients/client0/web2/web/includes/theme.inc(1580): block_list('right')
#6 [internal function]: theme_blocks('right')
#7 /var/clients/client0/web2/web/includes/theme.inc(617): call_user_func_array('theme_blocks', Array)
#8 /var/clients/client0/web2/web/includes/theme.inc(1774): theme('blocks', 'right')
#9 /var/clients/client0/web2/web/sites/www.menashalibrary.org/themes/fb_fbml/template.php(30): template_preprocess_page(Array, 'page')
#10 [internal function]: fb_fbml_page('
$_REQUEST:
Array
(
    [q] => admin/build/block/list/fb_fbml
    [3b30ab62198bbd5e409f902ba37827e4] => f26b5a456dc7448494cb86f3590fdd6f
    [3b30ab62198bbd5e409f902ba37827e4_expires] => 1243695600
    [3b30ab62198bbd5e409f902ba37827e4_session_key] => 3.Q8myCw4rxMHcYtbVz41pHQ__.86400.1243695600-1335487366
    [3b30ab62198bbd5e409f902ba37827e4_ss] => XRf2tzQqrsk4iZE2xTDmuQ__
    [3b30ab62198bbd5e409f902ba37827e4_user] => 1335487366
    [__utma] => 116135066.3695051843684078600.1226549338.1233162571.1233166436.73
    [__utmz] => 116135066.1228258210.9.2.utmcsr=upgrade.menashalibrary.org|utmccn=(referral)|utmcmd=referral|utmcct=/admin/settings/performance
    [base_domain_3b30ab62198bbd5e409f902ba37827e4] => menashalibrary.org
    [fb_canvas_11722_SESS8ca7c826e2a224dd5c7e4d73cb733038] => fb_canvas_11722_2.smnHw7rUiStep_nnWiuppw__.86400.1242136800-1335487366
    [fbsetting_3b30ab62198bbd5e409f902ba37827e4] => {"connectState":1,"oneLineStorySetting":2,"shortStorySetting":2,"inFacebook":false}
    [SESS8ca7c826e2a224dd5c7e4d73cb733038] => fb_connect_3.Q8myCw4rxMHcYtbVz41pHQ__.86400.1243695600-1335487366
    [_csuid] => 46090f09039ddec8
    [has_js] => 1
    [icid] => 0
    [idsc] => 0
    [ih1] => 264
    [ih2] => 132
    [iw1] => 132
    [iw2] => 632
    [sessionCookie] => L0FWOB792SYMH019LJBXAG9JFTTMSXUF
    [wooTracker] => 2EE2OG9A4I8X5VOQUQQWKHJ3MPNAXZXE
)


REQUEST_URI:
/admin/build/block/list/fb_fbml

Since that's all that's on the screen, I'm not able to remove those blocks. so, now my app is just showing that error. Any ideas how I can fix this?

#1

Dave Cohen - May 29, 2009 - 22:08
Assigned to:Anonymous» Dave Cohen

Whoops. Look for:

    // Our blocks use current application                                      
    global $fb, $fbu;

and make it say
    // Our blocks use current application                                      
    global $fb, $fb_app;

Will check this in when I get a moment.

#2

georgedamonkey - June 1, 2009 - 16:25

I made the change you mentioned in fb_friend.module and now I get this error on the screen. (it was easier taking a screenshot)

AttachmentSize
Picture 1.png 50.83 KB

#3

SocialNicheGuru - June 3, 2009 - 14:45

I can confirm.

I get the same error.

Chris

#4

Dave Cohen - June 3, 2009 - 18:31
Status:active» fixed

Thanks for pointing this out, guys.

I've checked this patch in.

AttachmentSize
fb_476570.diff 1.13 KB

#5

georgedamonkey - June 4, 2009 - 16:55

With the latest dev version, I am able to add the blocks in now. BUT, they don't actually display. I tried adding them to 'canvas right' where I have my other blocks.

#6

System Message - June 18, 2009 - 17:00
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

#7

mmatton - August 31, 2009 - 21:00
Status:closed» needs work

I'm getting the same as george, added just fine but nothing is showing up.

#8

mmatton - August 31, 2009 - 22:55

Oh, just looked into the code on this & it has "TODO: support canvas pages, in addition to connect pages." on everything. Since I'm using canvas pages that means me :(

#9

Dave Cohen - September 2, 2009 - 14:58
Category:bug report» feature request

Yeah, its a TODO item to support canvas pages. Patches alwas welcome to fix TODOs.

 
 

Drupal is a registered trademark of Dries Buytaert.