Legacy Drupal 5.x code and techniques in 6.x branch
ckng - June 1, 2009 - 09:56
| Project: | Block Class |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Todd Nienkerk |
| Status: | needs review |
Description
The following line ~55 is NOT needed in D6, $form['#validate'][] is an array which will call each validate functions added.
<?php
block_admin_configure_validate($form, $form_state);
?>
#1
Well there are more after look deeper into the code.
Attached is the patch that solves the following bugs:
- #410554: CSS Class Definition on "Add Block" page
- db updated on #validate, even if the block is not validated
- getting values from $form_state instead of arg()
- UI: remove the fieldset and make it part of 'Block specific settings', which is the common place
#2
ckng:
Thanks for all your work. I will take a closer look at the patch later today.
I won't implement the removal of the fieldset in the UI, however, as we are planning a major overhaul of this module that will require several configuration options. You can see these new features in the 6.x-1.x-dev snapshot.
#3
Correction: The latest changes are in HEAD. They will be committed back to 6.x.-1.x-dev later today.
ckng: When everything is copied back to 6.x-1.x-dev, would you be willing to reroll the patch? I'm pretty sure most (if not all) issues are fixed in that version. I'll post a comment here when HEAD has been moved back.
#4
ckng: I have re-rolled your patch to remove the UI change and use Unix line endings. Does this achieve what you'd like?
Also, HEAD has now been branched to 6.x-2.x (aka DRUPAL-6--2). This branch is significantly different from 6.x-1.x. We will need to port this patch to the 6.x-2.x branch.
#5
#6
Hi Todd,
Thanks, the patch looks good.