The following line ~55 is NOT needed in D6, $form['#validate'][] is an array which will call each validate functions added.

<?php
  block_admin_configure_validate($form, $form_state);
?>
CommentFileSizeAuthor
#4 block_class_cleanup_reroll.patch2 KBtodd nienkerk
#1 block_class-cleanup.patch2.2 KBckng

Comments

ckng’s picture

ckng
Primary language English
commented
Title: Duplicate validation » Multiple bugs
StatusFileSize
new block_class-cleanup.patch2.2 KB

Well there are more after look deeper into the code.

Attached is the patch that solves the following bugs:
- #410554: CSS Class Definition on "Add Block" page
- db updated on #validate, even if the block is not validated
- getting values from $form_state instead of arg()

- UI: remove the fieldset and make it part of 'Block specific settings', which is the common place

todd nienkerk’s picture

todd nienkerk commented
Title: Multiple bugs » Legacy Drupal 5.x code and techniques in 6.x branch

ckng:

Thanks for all your work. I will take a closer look at the patch later today.

I won't implement the removal of the fieldset in the UI, however, as we are planning a major overhaul of this module that will require several configuration options. You can see these new features in the 6.x-1.x-dev snapshot.

todd nienkerk’s picture

todd nienkerk commented

Correction: The latest changes are in HEAD. They will be committed back to 6.x.-1.x-dev later today.

ckng: When everything is copied back to 6.x-1.x-dev, would you be willing to reroll the patch? I'm pretty sure most (if not all) issues are fixed in that version. I'll post a comment here when HEAD has been moved back.

todd nienkerk’s picture

todd nienkerk commented
Version: 6.x-1.1 » 6.x-1.x-dev
StatusFileSize
new block_class_cleanup_reroll.patch2 KB

ckng: I have re-rolled your patch to remove the UI change and use Unix line endings. Does this achieve what you'd like?

Also, HEAD has now been branched to 6.x-2.x (aka DRUPAL-6--2). This branch is significantly different from 6.x-1.x. We will need to port this patch to the 6.x-2.x branch.

todd nienkerk’s picture

todd nienkerk commented
Assigned: Unassigned » todd nienkerk
ckng’s picture

ckng
Primary language English
commented

Hi Todd,
Thanks, the patch looks good.

todd nienkerk’s picture

todd nienkerk commented
Status: Needs review » Fixed

Pretty sure this was fixed awhile back. I just committed similar changes to the 6.x-2.x branch.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.