Closed (fixed)
Project:
Piwik Web Analytics
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Jun 2009 at 20:23 UTC
Updated:
18 Dec 2009 at 13:17 UTC
Jump to comment: Most recent file
Comments
Comment #1
pebosi commentedComment #2
hass commentedLooks like a stolen API from GA... :-)
Comment #3
hass commenteddrupal_to_js adds double quotes automatically:
("'. drupal_to_js($trackfiles_extensions) .'"). And+ $script .= 'piwikTracker.setCustomVars({ '. implode(', ', $piwik_vars_fields) .' });';looks code wise wrong, too. Do not forget that $piwik_vars_fields could be empty...Comment #4
pebosi commentedim sure, piwik developers got some suggestions from other tracking api's, why not?
updated my patch.
regards
Comment #5
hass commentedI keep this open until the 0.4 you referenced becomes available. Than create a new release for Piwik 0.4 very soon.
Comment #6
hass commentedComment #7
hass commentedIs this a fake? Where can I find the info about this 0.4 version? The latest version from SVN still have the old code style... ???
Comment #8
hass commentedAh... found it. Do you know if there is a reason why enableLinkTracking() comes after trackPageView()? If this is a requirement than the patch still needs work.
Comment #9
pebosi commentedNo fake...
http://piwik.org/docs/javascript-tracking/new-js-tracking-api/
http://dev.piwik.org/trac/milestone/Piwik%200.4
regards
Comment #10
pebosi commentedthe order is equal.
regards
Comment #11
hass commentedGreat, thank you very much for the links! This patch needs some work... there are many new features I waited for a long time... we could add some more features - GA already have and I was made to remove in piwik... Internal site search tracking may be possible, too. We need to investigate more on this.
Comment #12
pebosi commentedmy patch should only move the basic tracking to the new api. new features will be in another patch, or did you just started to work on it? ;)
regards
Comment #13
hass commentedOk, but enableLinkTracking() need to come after pagetracker if I reed the dogs correctly. Isn't it?
Comment #14
pebosi commentedafter asking matthew from piwik about the order, i changed my patch as you suggested.
regards
Comment #15
hass commentedHave matt explained you something about the order? If required - why? My idea is the binding to all elements may takes time and shouldn't block the page tracking process. Therefore it is done as the very last step.
Have you tested your code???
if (!($track_outgoing = variable_get('piwik_track', 1))) {looks wrong to me. enableLinkTracking() sounds like - link tracking is not enabled by default...Comment #16
pebosi commentedthe reason is to give priority to the tracking of the current page, and then installing the tracker on all links; it's pretty much similar reallyregards
Comment #17
hass commentedComment #18
hass commentedI've committed the patch with a few changes and a bugfix for #15 to D5 and D6