Closed (fixed)
Project:
XML sitemap
Version:
6.x-2.x-dev
Component:
xmlsitemap_menu.module
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
5 Jun 2009 at 20:10 UTC
Updated:
19 Jun 2009 at 21:40 UTC
Just wondering: I've quite a lot of menu items disabled (they'll be used within a few weeks).
It seems like xml sitemap maps the pages linked to by these disabled menu items.
Is that by design?
Comments
Comment #1
dave reidDoes it produce them in the actual sitemap.xml output? xmlsitemap_menu does check the following things:
status = $menu_item['access'] && !$menu_item['external'] && !$menu_item['hidden']I think the hidden value means 'disabled' in the interface.
Comment #2
Marc Bijl commentedHi Dave,
As you seem to be online right now, here are my sitemaps:
- http://www.newoceanstravelogue.com/en-US/sitemap.xml (english)
- http://www.newoceanstravelogue.com/nl/sitemap.xml (dutch)
First thing I notice:
The english sitemap maps dutch nodes (e.g. the even node numbers are the ones of dutch pages).
Second thing I notice:
The english sitemap maps nodes which are not accessible by the user because the primary menu items which lead to these pages are disabled (e.g. http://www.newoceanstravelogue.com/en-US/graphic-design# and http://www.newoceanstravelogue.com/en-US/general-conditions)
May be it'll help when I unpublish these pages too, but before I do that, I'll wait for your reply ;)
Comment #3
dave reidI probably know what's happening. Even if your primary links to certain nodes are disabled, you still have the xmlsitemap_node.module which is indexing your nodes. Because those nodes (http://www.newoceanstravelogue.com/en-US/general-conditions) are visible to the anonymous users, they are included in the sitemap.
As far as not-same-language nodes being indexed in language-specific sitemaps, see #480490: Integrate with i18n.module and add hook_xmlsitemap_query_alter(). I tried a multilingual site and when I view my own test site in English, it doesn't hide any other lanugage nodes. For instance, I can go to http://www.newoceanstravelogue.com/en-US/node/10 (viewing your site in English, but viewing a Dutch node) and it works just fine. Hence, the sitemap indexes the content. I still haven't found out how to properly deal with this.
Comment #4
Marc Bijl commentedHey Dave,
Thnx for the quick answers! ;)
As far as I can see, it's all clear:
1. To prevent indexing of nodes behind disabled menu items, I should unpublish the nodes. That's fine for me, no worries.
2. To get the multi language issue solved, you need some more info; I'll see if I can help you with that issue (probably later).
Regarding the multi-language issue: I guess this won't be a problem for engines like Google?
I think we can see this issue (http://drupal.org/node/483302) as 'fixed'?
Comment #5
Marc Bijl commentedHmm Dave, not sure about this:
I have unpublished the nodes which are not accessible by menu items, and indeed, the sitemaps seem to be much cleaner now.
- http://www.newoceanstravelogue.com/en-US/sitemap.xml
- http://www.newoceanstravelogue.com/nl/sitemap.xml
However, I just noticed there some double rows. Do you see something strange here?
Should I open another issue for this?
Comment #6
dave reidYeah what's happening now is that you have a menu link to a node. Since both the actual node and the menu link have been indexed, it will currently show both urls in the sitemap. The item that has the last modification date and change frequency is the node. I haven't found a good solution for avoiding menu items that link to nodes, taxonomy terms, or users, which could end up duplicating links in the sitemap. The existing issue for this problem is at #454442: Disable duplicate links during regeneration.
Comment #7
Marc Bijl commentedNo worries mate, thnx for the info!
Good to know you're aware and working on it ;)