Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.patched version (4.7)
Admin interface
Administrative Options, Use Node Type in Link, check or uncheck: no effect
and
Default is checked. I can't save unchecked status.
Frontend
With the following texts a translation is not indicated:
"email this page"
"Message Body"
I save a translation, but am shown the english text.
Regards
quiptime
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | forward_0.module | 12.67 KB | quiptime |
| #5 | forward.module | 12.68 KB | quiptime |
Comments
Comment #1
seanrThe 4.7 version needs to be completely rewritten due to the new features in the 4.6 version. I'll work in that in a coupe of weeks once I have time to get drupal 4.7 set up somewhere. ;) There's also a lot of work yet to be done to the 4.6 version as well.
Comment #2
quiptime commentedHere is the fixed code for one bug:
file forward.module
line 116
old code
'#title' => 'Message Body',new code
'#title' => t('Message Body'),I found still another translation bug. FORWARD_TITLE is without function in the function forward_link(). After I changed the following lines, functions indicate the translated text.
line 228
old code
$links[] = l(t('email this %type', array('%type' => $forward_link_type)), "forward/$node->nid&cid=$node->cid", array('title' => FORWARD_TITLE), NULL);new code
$links[] = l(t('email this %type', array('%type' => $forward_link_type)), "forward/$node->nid&cid=$node->cid", array('title' => t('Forward this page to a friend')), NULL);line 237
old code
$links[] = l(t('email this %type', array('%type' => $forward_link_type)), "forward/$node->nid", array('title' => FORWARD_TITLE), NULL);new code
$links[] = l(t('email this %type', array('%type' => $forward_link_type)), "forward/$node->nid", array('title' => t('Forward this page to a friend')), NULL);line 242
old code
$links[] = l(t('email this %type', array('%type' => $forward_link_type)), "forward/$node->nid", array('title' => FORWARD_TITLE), NULL);new code
$links[] = l(t('email this %type', array('%type' => $forward_link_type)), "forward/$node->nid", array('title' => t('Forward this page to a friend')), NULL);Regards
quiptime
Comment #3
seanrAs I said, the 4.7 version of this module is out of date. Most of these should already be fixed in the 4.6 version. Please test that version ONLY until I am able to update the 4.7 version. If you can find bugs in the 4.6 version, I'd really apreciate that.
Comment #4
quiptime commentedI work with Drupal 4.7 and forward.module (patched cvs version). Is forward.module version 4.6 compatibly with Drupal 4.7?
Comment #5
quiptime commentedOk, here is the version (cvs with 4.7 patch) with that fixed all errors.
Version 4.6 has more functions. But this version is 4.7 compatibly and works well with most node types.
The file with the complete code is attached.
Regards
quiptime
Comment #6
quiptime commentedSorry,
I forgot to remove debug code. Use please attachment of this post.
quiptime
Comment #7
Tobias Maier commentedyou posted a patch which got not commited so it becomes the status "code needs review".
it is fixed when it got commited to cvs/head
btw. why do you make yourself so much work and write a patch for what which the module autor "postponed"
He told you to wait because he wants to port the 4.6-version to 4.7.
It would be much better if you MAYBE could help him to do this (ask him if he needs help)
please read how to make patches
because it is not a good practice to provide the whole module
and my last sentence to you:
welcome at drupal!
Comment #8
Tobias Maier commentedComment #9
quiptime commentedI found still another bug. Hopefully it is the latter.
It is an error in the backend. administer -> settings -> forward -> Administrative Options -> Flood Control Error
Can't save changes in the text area.
Here is the fix:
look for the following line (304)
'#default_value' => variable_get('forward_flood_error_msg', t("In order to prevent spamming, we limit the number of messages you can send in a one hour period. Please retry later.")),the new code of this line
'#default_value' => variable_get('forward_flood_error', t('In order to prevent spamming, we limit the number of messages you can send in a one hour period. Please retry later.')),Regards quiptime
Comment #10
Tobias Maier commentedComment #11
seanrHousekeeping - all of this should be fixed in the current CVS.
Comment #12
(not verified) commented