simplenews.install should not use t() in hook_schema()

mrfelton - June 7, 2009 - 17:01
Project:Simplenews
Version:6.x-1.0-rc6
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

Modules should not be using t() in hook_schema. For more details, see these notes about When to use st(), t() and get_t() in install and update functions.

For a number of reasons (see http://drupal.org/node/332123), including website performance and the desire avoid encouraging translators to spend time on work of possibly limited value, Drupal 7 and also Drupal 6.9 and later no longer use t() on these strings. You should include schema table and field descriptions as verbatim strings without wrapping them in localization code.

#1

Sutharsan - August 13, 2009 - 15:13
Status:active» fixed

mrfelton, thanks for the tip. I was not aware of this change, but it a good one.

Attached patch committed to HEAD and 6.x-1.x-dev

AttachmentSize
simplenews.484484.patch 11.52 KB

#2

System Message - August 27, 2009 - 15:20
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.