Hi Aaron

Firstly, thanks for the cool module! It has saved me heaps of time. I'm doing a Fusion Charts based project and I'm particularly interested in making this module work with Fusion Charts V3 (the paid-for version) and doing fancy JS updates.

Anyway, I've got it working so now I'd like to send my patches through to you one by one.

This patch removes the newline breaks from the XML output. So

$str_xml .= "</trendlines>\n";

becomes

$str_xml .= "</trendlines>";

The new lines cause problems when updating the Chart's XML using Javascript. Since they don't really do anything, I was hoping they could be removed?

CommentFileSizeAuthor
#1 fusioncharts-remove_br-486190-0.patch13.37 KBMark Theunissen

Comments

Mark Theunissen’s picture

Mark Theunissen commented
StatusFileSize
new fusioncharts-remove_br-486190-0.patch13.37 KB
Mark Theunissen’s picture

Mark Theunissen commented

My editor is also set to strip trailing whitespace automatically as per Drupal's coding convention, so the patch seems to have a number of lines that remove and add the exact same thing - what it's actually doing is removing extra whitespace.

aaron1234nz’s picture

aaron1234nz commented

Thanks Mark,

I look forward to seeing the patches, they are very welcome. Its nice to get patches rather than feature requests.

Aaron

Mark Theunissen’s picture

Mark Theunissen commented

Great! Do you want me to submit them now or would you rather work one by one, so that there is only ever one patch under consideration?

I find that will save me the work of having to reroll patches as you commit... ;)

I only really have another one or two actually (for now!)

aaron1234nz’s picture

aaron1234nz commented

one big patch is fine by me.

thanks

Aaron

Mark Theunissen’s picture

Mark Theunissen commented
Status: Needs review » Closed (duplicate)

Marking a duplicate of http://drupal.org/node/487596 because that patch contains this.