I read somewhere that Adsense Injector may be included in Adsense module soon. is this true? This would be great for it to be centralized!

Comments

vm’s picture

vm commented

Adsense Injector has been abandoned = http://drupal.org/project/adsense_injector

netentropy’s picture

netentropy commented

yes and there is a support issue asking permission to merge it with Adsense module, which is why I asked the question

http://drupal.org/node/475692

vm’s picture

vm commented

Hmm, I see. I guess I don't understand the point of this thread then when you could have commented on the other. Two issues designed to accomplish the same task doesn't make much sense and only causes confusion for users trying to figure out what is going on.

I'd dropped the link and note here (not for you) but for the devlopers of adsense so that they would know the project has been abandoned.

Now that you've actually located the previous discussion and linked it and based on the fact that one of the major contributors from adsense is the person who started the thread you linked to, this could be closed and discussion continued on the linked issue where the developer is already taking action.

netentropy’s picture

netentropy commented

The reason for this thread, is, as you said, Adsense injector is abandoned so there is no reason I should think the admin there would answer.

So the next logical step is to ask the admin's here. If in fact, I want an answer. Which would be point of starting a thread.

vm’s picture

vm commented

the thread you link to was STARTED by one of the major contributors of the adsense.module (this module) and there is a procedure that takes place with taking over modules. ie: waiting for original developer to respond, up to 2 weeks.

netentropy’s picture

netentropy commented

man, what is your deal. you don't have to lecture me on protocol.

I am aware it was started by one of the Adsense contributors which is why I asked here and not there again.

I am aware Adsense Injector was abandoned which is why I asked for the update here and not there again.

And it has been 2 weeks since the request, which is why I waiting to ask for an update until today (2 weeks from when the original request was made over there)

Sorry

vm’s picture

vm commented

No apologies necessary and I have no "deal"

But to clear up the issue you have with me:

When I'd originally dropped the link in #1, it was for the developer of adsense.module so that they knew the adsense injector.module was abandoned. Also of note that was before you linked to the actual discussion and I learned who authored the thread you linked to.

Because there is a documented procedure, I took the time to explain it to you so that you knew it could take up to two weeks to see any traction gained on the proposal. Also of note commenting on thread you linked to would send an email to the Original poster and hopefully get a faster response. I didn't consider the "developer" or "admin or adsense_injector. That isn't the person responsible for the thread you linked to.

Just because you started this issue doesn't necessairly mean I was trying to start a dialouge with you. You aren't the only person subscribed to this issue queue who would see the link I dropped.

netentropy’s picture

netentropy commented

That makes sense, thank you.

kbahey’s picture

kbahey commented

If Adsense Injector is abandoned, then we can merge it in this module, as an optional module.

Someone has to do the work for this and submit a working and tested patch.

When this is done we can put a note on the project page of adsense injector that it is now merged into adsense.

This should be for Drupal 6.x.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Closed (duplicate)

I am marking this as a duplicate of #475692: Merge into the Adsense module. Adsense injector will be a sub-module in the next released version of this module..

João