Merge into the Adsense module
jcnventura - May 28, 2009 - 18:46
| Project: | Adsense Injector |
| Version: | 6.x-2.x-dev |
| Component: | Miscellaneous |
| Category: | task |
| Priority: | critical |
| Assigned: | jcnventura |
| Status: | active |
Jump to:
Description
I see that this module is now abandoned.. I am planning to take this module and merge it into the adsense module, as (yet another) sub-module.
I have contacted hswong3i, but he hasn't answered to my private e-mail, so I am posting this in the module's issue queue..
The plan is to merge and then ask Drupal.org webmasters to delete this module, unless someone objects.
João Ventura
#1
I really hope so, the last time I tested this there was a bug with Views.
#2
discussion from commentor in #1 duplicated here: http://drupal.org/node/486316
#3
As I am only a co-contributor of adsense_injector, I have no right to discontinuous it and merge into adsense.module. BTW, I would like to duplicate code to adsense.module and keep contribute there for a long term support. Should this be a better solution?
#4
Hello, everyone. I am the new maintainer of adsense injector. I recently released the simplehtmldom module that is a very powerful html parser. This should help us implement some interesting insert-modes of adsense code into the html of nodes...
As for the merge - I am 50/50 on that currently:
go-merge: one module is better for the users, especially if the satelite module is so small + it was abandoned until recently when I took it over
do-not-merge: the support issue of a satelite module is specific to its scope - tag-injection (=more easily maintainable) + now it has a maintainer + it is 2nd in google when you search for "drupal adsense" - which makes people open both adsense and adsense injector's pages...
What does Joao think?