I see that this module is now abandoned.. I am planning to take this module and merge it into the adsense module, as (yet another) sub-module.

I have contacted hswong3i, but he hasn't answered to my private e-mail, so I am posting this in the module's issue queue..

The plan is to merge and then ask Drupal.org webmasters to delete this module, unless someone objects.

João Ventura

Comments

netentropy’s picture

netentropy commented

I really hope so, the last time I tested this there was a bug with Views.

vm’s picture

vm commented

discussion from commentor in #1 duplicated here: http://drupal.org/node/486316

hswong3i’s picture

hswong3i commented

As I am only a co-contributor of adsense_injector, I have no right to discontinuous it and merge into adsense.module. BTW, I would like to duplicate code to adsense.module and keep contribute there for a long term support. Should this be a better solution?

rsvelko’s picture

rsvelko commented

Hello, everyone. I am the new maintainer of adsense injector. I recently released the simplehtmldom module that is a very powerful html parser. This should help us implement some interesting insert-modes of adsense code into the html of nodes...

As for the merge - I am 50/50 on that currently:
go-merge: one module is better for the users, especially if the satelite module is so small + it was abandoned until recently when I took it over

do-not-merge: the support issue of a satelite module is specific to its scope - tag-injection (=more easily maintainable) + now it has a maintainer + it is 2nd in google when you search for "drupal adsense" - which makes people open both adsense and adsense injector's pages...

What does Joao think?

kevster111’s picture

kevster111 commented

The google value alone makes me think you should keep it seperate, or merge but leave this here and you could help maintain the sub module under the Adsense module.

Its your decision obviously. I bumped an old issue just a bit ago before seeing this post, didn't know there wasn't and now is a new maintainer. The post was about different injector templates into different node types. If keeping this module alive here helps bring this option to the adsense injector I vote for keeping it here. If it can be done easy either way then no vote needed lol.

summit’s picture

summit commented

Hi, Any progress on this migration please I see post: http://drupal.org/node/486316 but then it stops..?
If I missed it very sorry to post this.
greetings, Martijn

HS’s picture

HS commented

I suggest not merging and moving away from Adsense module. This module should be able to inject ANY advertising code not just Adsense. That would make the module very useful to many.

mcurry’s picture

mcurry commented
Assigned: jcnventura » Unassigned
Priority: Critical » Minor
Status: Active » Closed (won't fix)

The module is now under a new maintainer (me) -- I'm the original author. Sorry I've been away so long, but now it's time to get this project rolling again.

We're not going to merge adsense_injector into the adsense module.

In fact, I'm going to decouple this module from any dependency on the adsense module: it will use the adsense module if it's installed, otherwise, no dependency.

As to @HS comment RE supporting ANY advertising code, it already does. You can inject *any* arbitrary code/text/HTML/whatever in your templates now, as has been the case from day one–which is one, but not the only, very good reason why it won't be rolled into the adsense module.