I am back again on this module after a period of time.

Again, I would like to thank you for this module that is very useful and has continued to be improved since I last used it.

I would specifically like to ask about the default weblinks.css file and the minimal and fancy files.

I understand that the weblinks_minimal.css can be used to work with the theme but you have chosen to make the default a slightly enhanced css. I still wonder if this is the right thing to do. It still appears to me that it would be better for the module default to work with the theme and that further enhancements should be available for the user to configure.

I am not sure what the consensus is but I would suggest that the minimal css file be the default, and the others be named standard or enhanced and fancy. Just a thought. I promise not to keep harping on this as it is quite easy for me to live with things the way they are.

Thanks,

Izzy

Comments

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Actually, I have not been updating the "minimal" and "fancy" as I have made the changes that I have. As far as I am concerned, I would just as soon remove "minimal" and "fancy" from 6.x-2.x.

I will defer to Robert on this one.

BTW, also see CSS API.

izmeez’s picture

izmeez commented

If the "minimal" and "fancy" css files are removed could the standard weblinks.css file be deleted by those who want the theme to takeover?

Thanks,

Izzy

dbeall’s picture

dbeall commented

does the cssAPI fix the new web links so they display normally? The links are huge, with read numbers and comments.. changing back to old version to fix all problems.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

@izmeez: No, if you delete it entirely, then you will get an error message when we try to add the CSS file. You are free, however to delete everything in the CSS file; just be aware that some of that is for making the settings pages more compact and looking better.

@dbeall: Version 2 is much more core theming that Version 1. If you see stuff showing up now that wasn't there before, it is because you have other modules incorrectly set up (for example read counts is from Statistics and comments are from Comments); we can't fix those for you. Everything else is the CSS, either yours site's or from the weblinks.css files (and you may change those).

dbeall’s picture

dbeall commented

Thankyou for the info, I wasn't sure what was doing all that. I did see a lot of extra goodies in it, I will play with the css files. i like your 6.16 better, The style in that one is cleaner than the theme style is. I really like your module a lot. It serves a big purpose easily, and my visitors like it too.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

I suspect that once you get used to all that can be done with V2, you will like it better. All the "bolt-on" modules, like ratings modules, should now work as we are pretty close to core-standard functionality and the normal Drupal hooks should function correctly. We are now very close to a full theme-layer standard so that you are free to do what you want rather than what we want.

We are continuing to work towards an API-and-implementation-wrapper module, eventually going to Fields (CCK) and Views support. Also search our tags for "Roadmap" to see the more immediate plans for improvement. We want to be the premier links module in Drupal.

izmeez’s picture

izmeez commented

Well, I think you are well on the way to being the "premier links module in Drupal" and you also deserve an award for the most responsive support.

You might need to keep the option of the minimal css file or document that people can edit out what they don't want from the standard css file.

Thanks a lot,

Izzy

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Active » Postponed (maintainer needs more info)

An interesting observation: I am using the Pixture_reloaded theme on my test site and when I switched to the minimal css file, the only difference I see is that the background color on the error messages goes away. Otherwise the standard css and the theme-only displays are the same. So I guess this problem largely depends on your theme; when I used Garland, the standard display was bad (IMO) and that was why we developed the standard css file.

Perhaps what we should do is to take the "standard" css file and mostly make it comments so that people can see examples of what might work for them. Then delete the other two css files entirely.

rmiddle’s picture

rmiddle commented

Nancy since we moved to using drupal's default node view system maybe we need to revisit this. Also in 6 we load the .css files using hook_init correct? I wonder how inefficient it would be to have a few options .css files decided by a system variable?

Thanks
Robert

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Well, actually, the CSS is now added in hook_help (that's why it is a dependency). Maybe by the time I can get back to it, they will have some documentation for the CSS API module.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Okay, the admin CSS is now split out into weblinks.admin.css.

Next, contribs get their own CSS files...

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Okay, contribs done.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented

Izzy and Robert, after cleaning up the CSS files, I find that there is only one class in the standard CSS that is not in "minimal," and that is for the click count information. That class should probably be in "minimal" anyway.

I have not looked at "fancy," but I consider that more "fluff" than anything else. Fancy started as a way to make Garland (and Color) look decent. It was intended to be merged into the site CSS rather than remain separate. As several people have pointed out, that customization should really be the site admin's job.

As part of cleaning the CSS up, I added a lot of comments to guide the admin.

At this point, I see absolutely no real reason to distribute three CSS files and would like to delete the other two.

nancydru’s picture

nancydru
she/her/hers
Primary language English
Location Boston
commented
Status: Postponed (maintainer needs more info) » Fixed

Per discussion with Robert, "minimal" and "fancy" are now deleted from the distribution.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.