Tab selection fails on IE7

ndeschildre - June 10, 2009 - 14:25
Project:Quick Tabs
Version:6.x-2.0-rc3
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs work
Issue tags:Release blocker
Description

Hello,

I'm using a quicktabs on IE7. When the page is loaded, it will hide the first tab page. When clicking the second tab link, it will show the first tab page. When clicking the third tab link, it will show the second page, and so on...
I've debugged a bit, and key happen to return 'indexOf' at some point. As a result, i is not right. Not really sure why it happens. See the patch.

This bug only affect IE7 (IE8, FF ok), this patch correct the issue on these browsers.

Thanks!

AttachmentSize
quicktabs-ie7.patch659 bytes

#1

Pasqualle - June 10, 2009 - 15:20
Category:bug report» support request

I have tested this, the tab selection works without problem in IE7..
the patch is wrong as key can be a string and tabIndex is a number..

first thing you should check, if the page is a valid HTML, as that is the most common problem when something does not work in some browsers..

use http://validator.w3.org/
or the firefox plugin: Html Validator

#2

ndeschildre - June 11, 2009 - 08:50

Weird.

I'll look deeper on that.

Thanks.

#3

kotu - July 2, 2009 - 23:12

I had the same problem (#508284: Tab's content is moved to next tab (IE6 & IE7)), patch listed above solves it so far...

#4

Pasqualle - July 18, 2009 - 03:43
Category:support request» bug report
Status:active» needs work

I confirmed the issue in #508284: Tab's content is moved to next tab (IE6 & IE7) so this is actually a bug, but the patch is not good enough as described in comment #2.

#5

Pasqualle - July 18, 2009 - 03:48

tagging

#6

asak - August 12, 2009 - 13:58

The patch works for me...

Has anyone had any actual problems because of it...?

#7

Pasqualle - August 12, 2009 - 15:11

yes,
#2: the patch is wrong as key can be a string and tabIndex is a number..

#8

asak - August 12, 2009 - 17:32

@Pasqualle: can you say that in a practical kind of way...?

I truly don't understand what that really means, and would appreciate if you could use an example for all us dummies ;)
And.. everything does seem to work... so if simply must refrain from doing something (which apparently i haven't done yet) that could be an acceptable workaround for now...

Thanks!

#9

Pasqualle - August 12, 2009 - 20:11

if you create the quicktab through the admin UI, then the tab key is 0, 1, 2, 3 ..
but it you create the quicktab with code #332895: render quicktab programatically, then the tab key could be anything like 'first', 'second', 'third'
in this case the patch will break the functionality..

 
 

Drupal is a registered trademark of Dries Buytaert.