Download & Extend

chatroom use theme('username') instead of l(...)

Project:Chat Room
Version:6.x-2.9
Component:Code
Category:bug report
Priority:normal
Assigned:beejeebus
Status:closed (fixed)

Issue Summary

In both the messages and user list, chatroom generates its own text and links for users. Is there any reason why theme('username', ...) was not used?

I have a site that needs to override theme('username',...) and I can't figure out how to override the text that chatroom displays.

Thanks for any help.

Comments

#1

no? nothing?

#2

I have the issue, this module uses JS to get username so would be great if someone helps?

#3

Version:6.x-1.0-beta2» 6.x-1.0-beta3
Assigned to:Anonymous» beejeebus

#4

Status:active» needs review

seems this was half done. i've committed fixes to finish the job. the site-wide user list is broken right now anyway...

#5

Status:needs review» fixed

#6

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#7

Version:6.x-1.0-beta3» 6.x-2.9
Status:closed (fixed)» needs review

Hello,

I've just installed Chat Room 6.x-2.9, the usernames are still not displayed through the theme function. Looking at the code in theme_chatroom_message(), I can still see l() instead of theme('username', ...) .

Changing it to something like this seems to work:

<?php
   
//$username = l($message->name, 'user/'. $message->uid);
   
$username = theme('username', $message);
?>

#8

Status:needs review» fixed

thanks ball.in.th. i've committed the fix from #7, will roll a 6.x-2.10 release later today.

#9

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here