Posted by hutch on June 11, 2009 at 10:24pm
| Project: | Thickbox |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | hutch |
| Status: | closed (won't fix) |
Issue Summary
The attached patch and file will enable thickbox to be used as a replacement for the existing inline iframe in the imagepicker module
The patch is on thickbox.module and adds code to enable thickbox_imagepicker..js before thickbox.js is called.
thickbox_imagepicker_js.txt will need to be renamed to thickbox_imagepicker.js and placed in the thickbox folder
I will be posting matching patches on http://drupal.org/project/issues/imagepicker shortly
Feedback welcome
| Attachment | Size |
|---|---|
| thickbox_imagepicker_js.txt | 619 bytes |
| thickbox_imagepicker.patch | 624 bytes |
Comments
#1
These patches are now redundant, a better way to integrate thickbox with other modules is to use 'module_invoke_all'
patch attached, copy to the thickbox folder and apply with the following command
patch -p0 < thickbox_addhook.patch
Alternately add the following line to function _thickbox_doheader() in thickbox.module
module_invoke_all('thickbox_js');immediately above
drupal_add_js($path .'/thickbox.js');To see how this works have a look in the imagepicker module 2.x-dev, imagepicker.module function imagepicker_thickbox_js() and imagepicker_thickbox.js
This patch will extend thickbox without in any way interfering with existing functionality.
#2
Please test the new Colorbox module and see it that works better.
http://drupal.org/project/colorbox
I have ported all Thickbox features to Colorbox so it should work as a drop in replacement.
When Colorbox has a stable release I will start actively recommend people to switch/upgrade from Thickbox to Colorbox. I'm the maintainer of Thickbox and a co-maintainer of Colorbox.
#3
I'm the maintainer of Imagepicker and would just like to say that Colorbox is the way to go, Imagepicker integrates fully with Colorbox without any ugly hacks or bodges, same goes for my Getdirections module which will give you a googlemap in a Colorbox.
Keep up the good work frjo ;-)