Rules integration: rules event when submitting feedback
pvhee - June 15, 2009 - 11:55
| Project: | Feedback 2.0 |
| Version: | 6.x-2.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Description
This is related to #353548, but focuses on the contrib module rules instead of the core triggers/actions.
Attached in the .tgz are two files:
- patch for feedback.module, which invokes a rules event ("feedback_add_entry") when new feedback is added. For now, only the user providing the feedback is passed on, but I am working on passing the message, the location and all other relevant data as well.
- file 'feedback.rules.inc', which defines the feedback event. This allows the rules module to use this event.
You can now easily send out emails whenever new feedback is added, or any other action provided by rules or contrib modules, using the entire $user variable.
Would there be a possibility to add this patch to the rules module? If so, I will elaborate on the implementation in feedback.rules.inc, providing more data for conditions and triggers.
| Attachment | Size |
|---|---|
| feedback_rules_patch.tgz | 787 bytes |
#1
I forgot the [ ] around the issue I refered to, here it is: #353548: Add trigger/action for e-mail notification
#2
subscribing
#3
+1
#4
Here is a new patch, passing the feedback message and location as arguments in the event (as rules strings). Now you can use those in your actions/conditions, eg to send out email with the actual message and the location it was submitted at.
Coding conventions of the patch have been checked as well, and I've successfully tested it already on multiple sites.
#5
Any feedback on this? Could this be included in the latest dev? Thanks!
#6
Cool patch. I implemented it in my own feedback module and it works quite well! Thanks! (PS: Maybe is posting text files more convinient for admins to check your patch)
#7
Could you please provide a proper patch? See http://drupal.org/patch for further information.
#8
Attached is a proper patch.
I now pass the following variables to the rule: user, feedback message, feedback location, masked path location and the HTTP_USER_AGENT.
#9
+++ feedbackNew/feedback.module 2009-08-07 14:51:48.000000000 +0200@@ -142,6 +142,12 @@ function feedback_form() {
+
...
+ global $user;
...
+
Trailing white-space here.
+++ feedbackNew/feedback.rules.inc 2009-08-07 14:51:48.000000000 +0200@@ -0,0 +1,24 @@
+ * @file rules integration for the feedback module
"@file" should be on an own line, "Rules integration..." right below it. Also note proper capitalization for "Rules" and "Feedback". And there should be a trailing period (full-stop).
+++ feedbackNew/feedback.rules.inc 2009-08-07 14:51:48.000000000 +0200@@ -0,0 +1,24 @@
+ 'label' => t('User gives feedback'),
I think we should label this event "Feedback is submitted" - or - any better suggestions welcome.
+++ feedbackNew/feedback.rules.inc 2009-08-07 14:51:48.000000000 +0200@@ -0,0 +1,24 @@
+ 'module' => 'Feedback',
Shouldn't this be lower-case? (sorry, I'm not very familiar with Rules)
+++ feedbackNew/feedback.rules.inc 2009-08-07 14:51:48.000000000 +0200@@ -0,0 +1,24 @@
+ 'feedback' => array('type' => 'string', 'label' => t('feedback message')),
+ 'location' => array('type' => 'string', 'label' => t('feedback location')),
+ 'location_masked' => array('type' => 'string', 'label' => t('feedback location masked')),
+ 'useragent' => array('type' => 'string', 'label' => t('user agent')),
I think the key should be "message" instead of "feedback".
Also, all labels should be properly capitalized, i.e. "Feedback message".
"Feedback location masked" we should change to "Feedback location (masked)".
Beer-o-mania starts in 24 days! Don't drink and patch.
#10
Thanks for reviewing the patch. I've changed the patch to accommodate to your comments. I haven't changed the capitalization in all cases though, as I'm following the standards set by Rules. Example:
'feedback' => array('type' => 'string', 'label' => t('feedback message')),Should be "feedback message" instead of "Feedback message". Same for "'module' => 'Feedback'".
#11
I applied the patch -- and it almost works. I can create a rule but the tokens are all wrong except for acting user. The other token patterns only show generic global tokens. For example, there's no token to place the feedback message in the email.
I don't really know enough about rules to be much help beyond that.
#12
subscribing
#13
Subscribing, greetings, Martijn