Closed (fixed)
Project:
Outline Designer
Version:
6.x-1.1
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
18 Jun 2009 at 14:23 UTC
Updated:
20 Jul 2010 at 20:10 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
looplog commentedI had this same issue, as seen at http://drupal.org/node/464946. Turns out there is apparently an issue with later versions of Thickbox. As per the project page, it is necessary to use Thickbox 6.x-1.2.
Comment #2
looplog commentedI just did a clean install using Thickbox-6.x-1.2 and the problem is still there, so I may have spoken to soon.
Comment #3
shunting commentedI have installed Thickbox-6.x-1.2 and the problem persists for me, too. Too bad, because book is sorely underpowered, and this is a potentially great module.
Comment #4
sam6 commentedSame issue with our installation
Comment #5
btopro commentedyeah, it's actually an issue w/ AHAH that causes a need for this to be turned on. Got added in recently bc it just flat out wouldn't work without it for some reason. If someone can track it down and make AHAH play nicely w/ it w/o clean urls i'll definitely roll this in as it's an issue that's annoyed me too.
Comment #6
tallsimon commentedi would love to see a solution to this but i am not a php developer.
I am willing to test, however!
Comment #7
btopro commentedunfortunately I think it's a problem with the ahah framework as that's where the issue emerges if you force clean url to turn on for this.
Comment #8
Anonymous (not verified) commentedI'm not sure what the conflict was... But I adjusted the code that was disabling clean urls and modifed the AJAX calls to use clean versions. It works for me. I can drag and drop the outline and create new pages.
Comment #9
btopro commentedTwo issues with this patch.
1. does the edit mode still work for it because my testing previously it wouldn't. AHAH based ajax calls screw up from my past experience unless this has been fixed in newer versions of Drupal.
2. This patch now makes the assumption that clean urls are enabled without checking. Not all setups support clean urls in the first place so while OD may make things goofy for people using clean URLs, it now wouldn't work for those not using it with this patch.
Comment #10
tallsimon commentedAny progress with this? Presumably this prevents a large number of people from using this module, as they use clean URLs...
Comment #11
btopro commentedUntil ahahs issues with the code kicked back are fixed I don't know that this will be resolved. I would say its specifically this modules issue but I followed the ahah methods as speced out and it would only work with cleans off. Easy enough to turn back on after the fact which is how we handle it. Ill accept patches to fix it but I don't see clean urls as a huge issue when its a minor one setting change. Network manager also helps keep you aware of the setting change.
Comment #12
pavel.karoukin commentedHello,
I just tried to remove variable_set('clean_urls', '0') from code and it worked fine as is. Where was this problem? May be something already fixed?
On another note - to make this work automagically - you might try to use url() instead base_path() . '?q=....'. I could do this myself and submit patch, but can't find an issue with AHAH. If you could point to it - I can play with it and submit patch with using url().
Regards,
Pavel
Comment #13
btopro commentedThat sounds promising, I'll do a fresh D6 install locally with all required versions and take that line out and see what happens now. Might have happened in a core version at some point and I missed it as it seemed very minor.
Comment #14
btopro commentedOk, I was able to verify that this works with Drupal 6.15 and the newest version of the AJAX module and prepopulate.
All I need now is someone using TinyMCE plugged in with this to verify, don't have the time to config it right now. If that's golden I'll definitely roll out a new version with this small, major change. I'd alos like some more verification that this does work for other people if they comment out line 45 in outline_designer.module.
Comment #15
pavel.karoukin commentedactually my site uses tinymce and it's fine also after removing this variable_set()
Comment #16
btopro commentedI just applied the patch then tried to duplicate some data and got a 404 error on the HTML return, anyone else able to replicate this?
Comment #17
btopro commentedCurrently, new build (relying on less outside code) seems to be working with this fixed. I really want to commit this but gotta test on my server first to see if it becomes an issue again. It could be an issue of scale of the data being sent across AHAH. I'll keep you posted.
Comment #18
btopro commentedWow this was a stupid error on my part. It's fixed now in 1.1