Posted by mathieso on June 18, 2009 at 2:23pm
| Project: | Outline Designer |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Thnx for the module. Great for doing book work.
Outline designer seems to turn off clean URLs. Here's how I reproduce on my site:
Start out with clean URLs on, at home page.
http://coredogs.com/ - All ok, when mouse over primary links, clean URLs show in browser status bar.
Go to http://coredogs.com/admin/content/book/list (the book list, I have three) - All ok, clean URLs.
Click on "edit order and titles" a book. This goes to:
http://coredogs.com/admin/content/book/6
At this point, the clean URLs are off. For example, mousing over the Books link in my primary menu shows http://coredogs.com/?q=book
Go to: http://coredogs.com/?q=admin/settings/clean-urls - shows clean URLs are disabled.
Kieran
Comments
#1
I had this same issue, as seen at http://drupal.org/node/464946. Turns out there is apparently an issue with later versions of Thickbox. As per the project page, it is necessary to use Thickbox 6.x-1.2.
#2
I just did a clean install using Thickbox-6.x-1.2 and the problem is still there, so I may have spoken to soon.
#3
I have installed Thickbox-6.x-1.2 and the problem persists for me, too. Too bad, because book is sorely underpowered, and this is a potentially great module.
#4
Same issue with our installation
#5
yeah, it's actually an issue w/ AHAH that causes a need for this to be turned on. Got added in recently bc it just flat out wouldn't work without it for some reason. If someone can track it down and make AHAH play nicely w/ it w/o clean urls i'll definitely roll this in as it's an issue that's annoyed me too.
#6
i would love to see a solution to this but i am not a php developer.
I am willing to test, however!
#7
unfortunately I think it's a problem with the ahah framework as that's where the issue emerges if you force clean url to turn on for this.
#8
I'm not sure what the conflict was... But I adjusted the code that was disabling clean urls and modifed the AJAX calls to use clean versions. It works for me. I can drag and drop the outline and create new pages.
#9
Two issues with this patch.
1. does the edit mode still work for it because my testing previously it wouldn't. AHAH based ajax calls screw up from my past experience unless this has been fixed in newer versions of Drupal.
2. This patch now makes the assumption that clean urls are enabled without checking. Not all setups support clean urls in the first place so while OD may make things goofy for people using clean URLs, it now wouldn't work for those not using it with this patch.
#10
Any progress with this? Presumably this prevents a large number of people from using this module, as they use clean URLs...
#11
Until ahahs issues with the code kicked back are fixed I don't know that this will be resolved. I would say its specifically this modules issue but I followed the ahah methods as speced out and it would only work with cleans off. Easy enough to turn back on after the fact which is how we handle it. Ill accept patches to fix it but I don't see clean urls as a huge issue when its a minor one setting change. Network manager also helps keep you aware of the setting change.
#12
Hello,
I just tried to remove variable_set('clean_urls', '0') from code and it worked fine as is. Where was this problem? May be something already fixed?
On another note - to make this work automagically - you might try to use url() instead base_path() . '?q=....'. I could do this myself and submit patch, but can't find an issue with AHAH. If you could point to it - I can play with it and submit patch with using url().
Regards,
Pavel
#13
That sounds promising, I'll do a fresh D6 install locally with all required versions and take that line out and see what happens now. Might have happened in a core version at some point and I missed it as it seemed very minor.
#14
Ok, I was able to verify that this works with Drupal 6.15 and the newest version of the AJAX module and prepopulate.
All I need now is someone using TinyMCE plugged in with this to verify, don't have the time to config it right now. If that's golden I'll definitely roll out a new version with this small, major change. I'd alos like some more verification that this does work for other people if they comment out line 45 in outline_designer.module.
#15
actually my site uses tinymce and it's fine also after removing this variable_set()
#16
I just applied the patch then tried to duplicate some data and got a 404 error on the HTML return, anyone else able to replicate this?
#17
Currently, new build (relying on less outside code) seems to be working with this fixed. I really want to commit this but gotta test on my server first to see if it becomes an issue again. It could be an issue of scale of the data being sent across AHAH. I'll keep you posted.
#18
Wow this was a stupid error on my part. It's fixed now in 1.1
#19
Automatically closed -- issue fixed for 2 weeks with no activity.