Recent comments is not respecting content selection mode
cronix - June 19, 2009 - 19:04
| Project: | Internationalization |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
The recent comments module is displaying the recent comments regardless of the corresponding node language. A list of recent comments is queried without looking at the comment language. That way german comments can show up next to russian comments in a multi-lingual site.
Shouldn't the recent comments query take the "content selection mode" setting into account when querying recent comments? That way only comments are shown that are respecting this setting.
I believe this should only be a minor modification of the query that is in function "comment_get_recent".
#1
#2
I have looked into this a little bit further. I now think this should be solved in i18n and not by modifying the query of the core modules. i18n seems to filter nodes based on the content selection mode setting, but comments are not filtered the same way.
#3
I basically agree, though at this stage this mean some functional change. I can imaging some other people wanting to behave the current way, so they get all comments for different languages.
So this will need some more ellaborated solution, maybe with options, patches welcomed.