Posted by sign on June 21, 2009 at 3:05pm
Jump to:
| Project: | Fivestar |
| Version: | 6.x-1.19 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
How to replicate this:
Post a comment without any stars
Edit the comment and highlight it with 1 star
Click Save -> presents 5 stars
The problem is on the line 184 in fivestar_comment.moduledb_query('INSERT INTO {fivestar_comment} (cid, value) VALUES (%d, %d)', $cid, $vote['user']['vote_id'], $value);
should be:db_query('INSERT INTO {fivestar_comment} (cid, vote_id, value) VALUES (%d, %d, %d)', $cid, $vote['user']['vote_id'], $value);
patch attached
| Attachment | Size | Status | Test result | Operations |
|---|---|---|---|---|
| fivestar-comments.patch | 854 bytes | Ignored: Check issue status. | None | None |
Comments
#1
Committed to both 5 and 6 versions. Thanks!
#2
Automatically closed -- issue fixed for 2 weeks with no activity.
#3
This bug still exists over a year later in the most recent 6.x-1.19 release (2009-Oct-22)
A diff of 6.x-1.x-dev and 6.x-1.19 reveals that this is one of the only a few changes.
How 'bout a 6.x-1.20 release addressing this bug? The longer this bug exists, the more comments are getting registered with vote_id = 0 and I'm not sure there's a way to rebuild that data.
Maybe we could slip in the comment <-> vote views relationship into a release as well?:
http://drupal.org/node/859808#comment-3518436
The issues are somewhat related because the view relationship does no good if the vote_ids are all 0.
#4
Updating the version to 6.x-1.19
#5
This issue was addressed, but I think there were some changes in Voting API later on. The new problem is being taken care of here: #601160: Comment-cast ratings not deleted with comment.