Call-time pass-by-reference
doublejosh - June 23, 2009 - 21:27
| Project: | Forward |
| Version: | 6.x-1.8 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
I get this upon first installing the module...
Warning: Call-time pass-by-reference has been deprecated; If you would like to pass it by reference, modify the declaration of system_settings_form_submit(). If you would like to enable call-time pass-by-reference, you can set allow_call_time_pass_reference to true in your INI file in /home/tackydev/tackysmack/drupal6/sites/all/modules/forward/forward.module on line 377
AHHH!!!

#1
I have the exact same problem! If you open the forward.module and go to line 377, I changed the following:
system_settings_form_submit($form, &$form_state);
to the following:
system_settings_form_submit($form, $form_state);
Notice the '&' is gone. Testing it now to see if it still works
#2
http://us2.php.net/manual/en/language.references.pass.php
This seems to not affect the installation. But PHP will continue to warn of it as a warning (if u don't turn off PHP warnings). If you check the Drupal /modules/system/system.module file line 1041, you will see that the function definition already has a call by reference for $form_state variable.
#3
Ugh, copied that from the Drupal docs! Gonna have to put a hurtin on someone. ;-)
Fixed.
#4
#5
Automatically closed -- issue fixed for 2 weeks with no activity.