Date validation incorrect for days > 31 [#501416]

The date_is_valid function in date_api.module has a bug when checking invalid days. I believe the bug to be in line 1374 where the statement:

elseif (!date_valid_year($year) || !date_valid_month($month) || date_valid_day($day, $month, $year)) {

should be ... || !date_valid_day(...
Note the negation.

Comment	File	Size	Author
#2	date_validation.patch	526 bytes	arlinsandbulte

Comments

arlinsandbulte commented 15 May 2010 at 12:40

For the 6.x-2.x-dev version as of 2010-May-01. This error appears to be on line 1382.

arlinsandbulte commented 28 April 2012 at 11:59

Version:	6.x-2.2	» 6.x-2.x-dev
Status:	Active	» Needs review

Status	File	Size
new	date_validation.patch	526 bytes

Here is a patch for the above error.
I have not tested it yet. Just following the suggestion of refman1073...

arlinsandbulte commented 28 April 2012 at 12:08

Assigned:	Unassigned	» arlinsandbulte
Status:	Needs review	» Reviewed & tested by the community

This patch looks correct to me.
I will review the D7 code and commit this when I get the chance.

arlinsandbulte commented 28 April 2012 at 13:47

Status:

Reviewed & tested by the community

» Fixed

12 May 2012 at 13:50

Status:

Fixed

» Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.