Download & Extend
Comment Upload » Issues

Preview doesn't work on non-english sites

Posted by ankheg on June 25, 2009 at 7:03pm
Project:Comment Upload
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (fixed)
Issue tags:attach, preview

Issue Summary

Preview doesn't work on non-english sites, because some strings aren't wrapped in t().

String 538 'Attach'
String 556 'Preview' and 'Attach'

Login or register to post comments

Comments

#1

Posted by toemaz on July 4, 2009 at 6:10pm
Version:6.x-1.0-alpha5» 6.x-1.x-dev
Status:active» needs review

I had the same problem.
Find the patch attached.

AttachmentSize
comment_upload_preview.patch 1.44 KB

#2

Posted by toemaz on July 6, 2009 at 3:26pm

@ankheg I made a patch based on your initial post but I didn't get it to work yet. Have you been able to actually solve the issue or was your proposed solution just a hunch?

#3

Posted by ankheg on July 9, 2009 at 8:26pm

Yes, the problem's solved. Your patch seems ok.

#4

Posted by netaustin on July 14, 2009 at 8:01pm
Status:needs review» fixed

Patch looks good. Committed, thanks!

#5

Posted by System Message on July 28, 2009 at 8:10pm
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

#6

Posted by EllECTRONC on August 14, 2009 at 9:53pm

This patch works great! Thanx toemaz.

#7

Posted by lewmich on September 18, 2009 at 7:23am

Problem came back after updating Drupal to 6.14... It is weird because I have the newest Comment Upload module with patch commited... Someting else changed?

m.

#8

Posted by toemaz on September 18, 2009 at 7:28am

@lewmich
It has been committed: http://drupal.org/cvs?commit=237422 and so it's available in the D6 dev package.

#9

Posted by EllECTRONC on September 26, 2009 at 8:15pm
Status:closed (fixed)» active

updating Drupal to 6.14 and problem came back...
tested: 6.x-1.0-alpha5, 6.x-1.x-dev

No preview if text olny and if text and attach

don't wanna back to 6.13...

#10

Posted by toemaz on September 26, 2009 at 8:19pm
Status:active» closed (fixed)

There has been an FAPI change in 6.14. See for similar bug report http://drupal.org/node/579900
This 'new' issue has nothing to do with this one so resubmit a new issue.

#11

Posted by Boobaa on March 31, 2010 at 8:56am

Subscribing. Any chance for a release soonish with this change included?

#12

Posted by tilmankoester on June 7, 2010 at 7:39am
Status:closed (fixed)» active

Still isn't working in D6.16 with the latest dev version of comment_upload.
It's definitely the language, because switching to English enables comment preview again.

#13

Posted by .zLaW on September 8, 2010 at 11:32am

I just applied the patch to 6.x-1.0-alpha5 on a german site running Drupal 6.19

The patch works fine here. Users with de as language are now able to preview their comments.

Thank you!

Helmut

#14

Posted by toemaz on September 8, 2010 at 12:43pm

@zLaW it would have been more useful if you use the dev rather than alpha 5 and see whether it was still applicable. That way we could place this issue on RTBC.

#15

Posted by .zLaW on September 10, 2010 at 2:48pm

@toemaz - sorry, I didn't mean to be useless ;-)

I dl'd 6.x-1.x-dev today and tried it on my Drupal 6.19 site.

The dev version contains the changes found in the patch and preview works fine for users in german on this site.

Helmut

#16

Posted by toemaz on September 10, 2010 at 3:10pm
Status:active» closed (fixed)

So let's put it on fixed then.