Preview doesn't work on non-english sites, because some strings aren't wrapped in t().

String 538 'Attach'
String 556 'Preview' and 'Attach'

CommentFileSizeAuthor
#1 comment_upload_preview.patch1.44 KBtoemaz

Comments

toemaz’s picture

Version: 6.x-1.0-alpha5 » 6.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new1.44 KB

I had the same problem.
Find the patch attached.

toemaz’s picture

@ankheg I made a patch based on your initial post but I didn't get it to work yet. Have you been able to actually solve the issue or was your proposed solution just a hunch?

ankheg’s picture

Yes, the problem's solved. Your patch seems ok.

netaustin’s picture

Status: Needs review » Fixed

Patch looks good. Committed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

EllECTRONC’s picture

This patch works great! Thanx toemaz.

lewmich’s picture

Problem came back after updating Drupal to 6.14... It is weird because I have the newest Comment Upload module with patch commited... Someting else changed?

m.

toemaz’s picture

@lewmich
It has been committed: http://drupal.org/cvs?commit=237422 and so it's available in the D6 dev package.

EllECTRONC’s picture

Status: Closed (fixed) » Active
Issue tags: +preview, +attach

updating Drupal to 6.14 and problem came back...
tested: 6.x-1.0-alpha5, 6.x-1.x-dev

No preview if text olny and if text and attach

don't wanna back to 6.13...

toemaz’s picture

Status: Active » Closed (fixed)

There has been an FAPI change in 6.14. See for similar bug report http://drupal.org/node/579900
This 'new' issue has nothing to do with this one so resubmit a new issue.

boobaa’s picture

Subscribing. Any chance for a release soonish with this change included?

tilmankoester’s picture

Status: Closed (fixed) » Active

Still isn't working in D6.16 with the latest dev version of comment_upload.
It's definitely the language, because switching to English enables comment preview again.

.zLaW’s picture

I just applied the patch to 6.x-1.0-alpha5 on a german site running Drupal 6.19

The patch works fine here. Users with de as language are now able to preview their comments.

Thank you!

Helmut

toemaz’s picture

@zLaW it would have been more useful if you use the dev rather than alpha 5 and see whether it was still applicable. That way we could place this issue on RTBC.

.zLaW’s picture

@toemaz - sorry, I didn't mean to be useless ;-)

I dl'd 6.x-1.x-dev today and tried it on my Drupal 6.19 site.

The dev version contains the changes found in the patch and preview works fine for users in german on this site.

Helmut

toemaz’s picture

Status: Active » Closed (fixed)

So let's put it on fixed then.