Views Bulk Operations (VBO) 6.x-1.x-dev (2009-Jun-17)
SMS Framework 6.x-2.x-dev (2009-Jun-03)
Views 6.x-2.x-dev (2009-Jun-26)
Token 6.x-1.x-dev (2009-Jun-13)

the log regarding sms activity is also empty

CommentFileSizeAuthor
#13 views_sms_export.txt.zip1.68 KBAnonymous (not verified)
#13 views_sms_export.txt.zip1.68 KBAnonymous (not verified)
#12 smsview.zip1.08 KBAnonymous (not verified)
#10 sms_user_error.jpg30.91 KBAnonymous (not verified)
#7 sms_user_hack.jpg41.33 KBAnonymous (not verified)
#6 sms_user.patch1.48 KBgunzip

Comments

gunzip’s picture

gunzip commented

which sms gateway are you using ? can you describe how you do it (are you sending sms to users through a profile field ?)
if you try to send a sms to the same number(s) with smsframework the "classical way" does it work ? may I access a demo installation ?

for a simple log you can activate smsbulk_example module.

EDIT:

I've changed the code to show some debugging stuff (if you activate smsbulk_example module).
This should give you a hint on what's going wrong. you can get the latest version from cvs or wait 24h
for a new relase to be generated by drupal packaging system.

thank you for testing.

gunzip’s picture

gunzip commented
Status: Active » Postponed (maintainer needs more info)
Anonymous’s picture

Anonymous (not verified) commented

I've just updated* to SMS Bulk 6.x-1.x-dev (2009-Jun-29).
The gateway is clickatell.
I've set a dynamic field in content profile that pull-out the mobile number from sms_user with:
$sql = 'select number from sms_user where uid = %d';
return db_result(db_query($sql, $node->uid));

My smsframework just send sms for mobile number confirmation, but is not working for the rest. I don't have a demo installation, sorry.
I've activated smsbulk_example module, but I don't know how to use it.
I re-checked log and now I have following error: [8] Failed sending SMS: skipping empty number

*PS I'm also using plugin_manager. Your module was marked as "module needs to be updated", but the process is not working. So I updated it manually.

gunzip’s picture

gunzip commented
Title: just not sending sms » make smsbulk work with sms_user mobile field
Category: bug » task

well, now i get the point. smsbulk calls the view query (SELECT...) just once at the beginning. it cannot work with dynamic fields because
these are built looping through the rows after the main query is called. you have to copy the values from the old sms_user mobile field to the new content profile field manually, then rework the view to use the latter. anyway, i'm gonna check if i can make it work against sms_user mobile field (without content profile). i mark this as a task then.

about the plugin manager, i guess i cannot do anything, it has something to do with drupal packaging system magic.

Anonymous’s picture

Anonymous (not verified) commented

great, thanks for your work
I'll wait for your updates!

gunzip’s picture

gunzip commented
Assigned: Unassigned » gunzip
Status: Postponed (maintainer needs more info) » Closed (won't fix)
StatusFileSize
new sms_user.patch1.48 KB

ok, i'm not gonna fix this in my module because sms_user should add views support itself.

but, good news for you, I've made a patch that works with sms_user and adds a field 'SMS mobile phone number' to the User group in views
so you don't need content profile etc. if you already have collected numbers with sms_users. just make an User view and add that field.

the patch is against the latest development version (3 june) of smsframework.

$ cd smsframework/modules/
$ patch -p0 < sms_user.patch
Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new sms_user_hack.jpg41.33 KB

I applied your patch, but when I try to select the Mobile Number field I'm not able to select anyting (pls see the attached image)

Anonymous’s picture

Anonymous (not verified) commented
Category: task » bug
Status: Closed (won't fix) » Active
gunzip’s picture

gunzip commented
Status: Active » Closed (won't fix)

you have to create a User view, not a Node view (ensure to clear the cache beforewards).
please don't reopen this issue as it's not a bug in smsbulk module but a feature request for sms_user.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new sms_user_error.jpg30.91 KB

the problem was another sms_user_views module conflicting with yours. Anyway, I properly created an user views, but I still get the error:
[8] Failed sending SMS: skipping empty number.

I'll post future issues on sms_user module, sorry.

gunzip’s picture

gunzip commented

may i ask you which other sms_user_views module ?

if you want you can paste here the exported view and/or the full generated query
(the one you get when you click on preview in the view) so i can debug.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new smsview.zip1.08 KB

the module is now disabled, and doesn't conflict anymore. Anyway here are the attached module and the views export.

Anonymous’s picture

Anonymous (not verified) commented
StatusFileSize
new views_sms_export.txt.zip1.68 KB
new views_sms_export.txt.zip1.68 KB
gunzip’s picture

gunzip commented
Status: Closed (won't fix) » Fixed

it was my fault. the bug was caused by the fact that the running view was not the 'default' display.
i've committed the fix to the dev version, here's the patch:

http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/smsbulk/sms...

thank you for the support.

Anonymous’s picture

Anonymous (not verified) commented

IT'S WORKING!
thank you very much

Now I'll try to:
- regarding "Select the field that acts as mobile phone number", I'll try to pull automatically the Number Field from sms_user, instead to map it manually
- regarding "Country" I'd like to have international prefix into the number, otherwise Bulk Operations make no sense when you need to send to different destination at the same time (italy, france, etc)

gunzip’s picture

gunzip commented

can you open a new issue for this as a feature request ?

if i understand the first request is: the system should guess the phone number field automatically (in the dropdown select).

i don't understand the second request. you can put the prefix into numbers, the fact is that the clickatell gateway module
expects them coming from his own form, so it depends on the gateway module you're using...

Anonymous’s picture

Anonymous (not verified) commented

I opened a feature request here http://drupal.org/node/506234

Regarding the international prefix I was wondering if possibly do like in http://drupal.org/node/441650 at line:
<<<<<<<
The MSISDN numbers must now be specified in full international format. I removed the concatenation of the country code and phone number from the send function, as this causes pain when sending programatically. Users should be encouraged to use properly formatted numbers, including the E.164 country codes (without special chars like "+" or spaces).
<<<<<<<
...but I don't know how/where to put my request.

gunzip’s picture

gunzip commented

#441650: Updated Clickatell gateway module is the right place

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

BenK’s picture

BenK commented

Subscribing...

mos2710’s picture

mos2710 commented

Sorry gunzip to reopen this case.

I can't understand why the number field here ( "Select the field that acts as mobile phone number") couldn't work with a cck phone field. It would have been much easier (I think) to get the number from the user's profile. At the moment no field is displayed. Look forward to hear from you.

Thanks
Mos2710

gunzip’s picture

gunzip commented

sorry, i didn't understand, may you elaborate more ? you can have a cck field as phone number, indeed that's what this module is for. you can create an user view with the profile field that act as phone number as well. you are free to use cck with content profile _or_ a plain user profile field _or_ the sms_user phone field applying the patch above.