I was creating an event that occurs twice a week (every Tuesday and Friday) and noticed what appears to be a performace difference depending on whether I select repeat every week or repeat every day. When I chose repeat every week, the performance was noticably worse than when I selected repeat every day. Selecting every month or year also seemed to get worse performance, with year being the worst of all.
It seems to me, that if the advanced repeat options are set, the repeat every week/day/month/year options may not be relevant and should be ignored if they are. Whether this is programmatically feasible is another issue, but all possible performance boosts are appreciated.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | date_repeat_array_var.patch | 607 bytes | delzhand |
Comments
Comment #1
ampersat commentedAn interesting follow-up that may help diagnose some of the other bugs involving missing repeat occurrences:
When I set the repeat of my event to every day, the first Friday of every month was missing the recurring event. Changing to every week worked around this bug.
More generically, when I configured the repeat for every day and then individually selected every Sunday, every Monday, ..., and every Saturday under the advanced settings, all days in the first week of every month were missing the event unless the first day of the month was on the same day as the site-defined first day of the month (which is Sunday for me, but I confirmed that changing the site to another day affects this bug).
So there appears to be a bug specifically with dates repeated every day.
Comment #2
andrewtf commentedI just ran into this bug, too. In my case I was setting up an event that repeated every day except Monday, so I set it to repeat every day, and selected the appropriate days individually. When displayed in the calendar it skipped the first week of the month and resumed the event starting the first full week. That is, if the month began on a Wednesday, Weds–Sat were skipped and the event listing resumed on the first Sunday (i.e. the start of the first full week).
This was consistent across all months where the event occurred. Repeating "Every week" as recommended above solved the problem, but it's a little counter-intuitive for users.
Comment #3
delzhand commentedI found something while working on a separate issue that I think may be related. Found an instance of $form_values that ought to have been $rrule_values.
Comment #4
gpk commented@3: I'm not convinced this is related. I suggest you open an new issue to flag it up.
@2: as far as I understand, the correct usage of the repeat options for your use case would be to set a weekly repeat, because the pattern repeats on a weekly basis. I have also hit this problem and thought I'd encountered a peculiar bug. Possibly some UI enhancements could help prevent this kind of confusion. You will find various issues where others have had the same problem.
Not quite sure if "performance difference" in the original post refers to the same thing or something else.
Comment #5
damienmckennaUnfortunately the Drupal 6 version of the Date module is no longer supported. That said, we appreciate that you took time to work on this issue. Should this request still be relevant for Drupal 7 please feel free to reopen it. Thank you.