Cannot save settings after disabling "Enable Fivestar rating for the "vote" tag"

morningtime - July 1, 2009 - 16:19
Project:Fivestar
Version:6.x-2.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

On the page admin/content/node-type/[node-type]/fivestar, there is a checkbox at the top "Enable Fivestar rating for the "vote" tag". When removing the tick on that checkbox, all form elements are disabled. Neat.

Sadly, also the "Save" button is disabled. I cannot save the form.

#1

morningtime - July 1, 2009 - 16:29

The problem is on line 67 in fivestar-admin.js:

This piece of code also disable the "save" button:

$options.attr('disabled', 'disabled');

I don't know how to fix it. I just located where it is. // Commenting it solved my problem.

#2

MaskedMarauder - November 6, 2009 - 03:01

Just an update. The bug is still here. The disable script is still too greedy.

A less disruptive means to the same end is to add the phrase "input:not(#edit-submit)" to line 29 next to the #edit-fivestar exception.

#3

quicksketch - November 6, 2009 - 04:07
Status:active» fixed

Odd, I'm not seeing this on my local but it's very clear that it *should* be getting disabled. In your case of course it's *actually* getting disabled. This patch should correct the problem. I've committed it to CVS already. Thanks for the report!

AttachmentSize
fivestar_disable_save.patch 779 bytes

#4

System Message - November 20, 2009 - 04:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.