Missing vote tag under Views relationships

jdmcelica01 - July 4, 2009 - 19:22
Project:Fivestar
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:eaton
Status:closed
Description

First off, thank you very much for a great tool. Up until now I have been able to create all sorts of different views, which has been a lifesaver. The issue I am having involves the Vote Tag under Relationship 'Node: Vote results.' I created a CCK fivestar field for one of my content types and set the 'vote axis' to points. When I try to select 'points' under Vote Tag, it is not listed. I checked phpmyadmin and the votes are being saved with 'points' as the tag. I am not sure if there is something I am missing. Any assistance would be much appreciated.

Thank you.

#1

dereine - July 4, 2009 - 19:26

shouldn't this be a issue for fivestar?

views does not do the integration of fivestar or cck

#2

eaton - July 4, 2009 - 19:29
Project:Views» Voting API
Version:6.x-2.6» 6.x-2.x-dev
Component:User interface» Views Integration

I'll take a closer look at this in a moment. Thanks.

#3

eaton - July 4, 2009 - 19:33

Are you using version 2.0 or later of VotingAPI? Not one of the release candidates? Using a 'clean' copy of VotingAPI 2.1, I'm seeing the following in the Views relationships form:

#4

eaton - July 4, 2009 - 19:36
Project:Voting API» Fivestar
Version:6.x-2.x-dev» 6.x-1.x-dev
Component:Views Integration» Code
Assigned to:Anonymous» eaton

Aha, wait, I think I may be confused. You're talking about using the word 'points' as a vote tag in Fivestar, not using "point-style voting". Hmmm. Fivestar may need to implement a hook to announce to VotingAPI that it's using the extra tag data.

#5

jdmcelica01 - July 4, 2009 - 21:09

Thank you for the quick response, especially on the 4th of July. To answer your question I am using Votingapi 6.x-2.1.

Sorry for using the same name 'points' as a voting tag as it is an option under Value Type in Views. I changed the voting axis in fivestar to 'test' and when I tried to select 'test' under Vote Tag the option was not available. Shall I post this as an issue in fivestar?

Thank you

#6

eaton - July 5, 2009 - 03:40

I've moved it over to the Fivestar queue, but it's only an issue because of a change in VotingAPI 2.0's official release. I'll put a patch together in a bit and see if I can get it in. Thanks!

#7

jdmcelica01 - July 6, 2009 - 21:46

Thank you very much eaton for your assistance.

#8

eaton - July 7, 2009 - 04:36
Status:active» needs review

Initial stab at the patch.

AttachmentSize
fivestar-tags.patch 1.51 KB

#9

jdmcelica01 - July 10, 2009 - 16:50

Thanks for the patch. I will give it a try and let you know how it goes.

#10

eaton - July 10, 2009 - 17:58

Also, the -dev release of VotingAPI (soon to be VotingAPI 2.2) will include an 'other' option when building relationships that lets you choose tags/functions/etc that aren't explicitly announced by other modules.

#11

ezra-g - July 14, 2009 - 03:08
Title:Missing vote tag under relationships» Missing vote tag under Views relationships
Category:support request» task
Status:needs review» fixed

This patch looks good and Views generates the right query using a test tag. Committed.

Thanks!

#12

System Message - July 28, 2009 - 03:10
Status:fixed» closed

Automatically closed -- issue fixed for 2 weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.