Provide option for personal messages to be disabled, enabled, and required
koenvw - July 6, 2009 - 13:12
| Project: | Forward |
| Version: | 6.x-1.9 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed |
Jump to:
Description
This patch adds a setting to make the "personal message field" optional. Please note that this is different from "allowing" the personal message field. The default value for this setting is true, so this shouldn't affect existing installations.
This patch should also work around the problem described here.
| Attachment | Size |
|---|---|
| forward_required_message.patch | 1.79 KB |
#1
+1 to this change. I was confused by the language "Allow" vs. the behavior of the form. I wonder if it would be better to make it a radios element, though, with the options:
Then there's no confusion about the two checkboxes.
#2
Further input... fwiw, if the field is required, there's no good reason to check in the validate handler if it's actually been filled in unless you trim spaces off the end of the message to see if actual text was included. Also, this is a feature request and needed a more descriptive title.
#3
Hi Guys,
I peaked at the current -dev release, but it seems that this is not going to be part of it any time soon.
Do we have any plans to incorporate this feature request for the next release?
Cheers.
#4
A version of this will be in the next release (later today).
#5
#6
Automatically closed -- issue fixed for 2 weeks with no activity.