Provide option for personal messages to be disabled, enabled, and required [#511472]

This patch adds a setting to make the "personal message field" optional. Please note that this is different from "allowing" the personal message field. The default value for this setting is true, so this shouldn't affect existing installations.

This patch should also work around the problem described here.

Comment	File	Size	Author
	forward_required_message.patch	1.79 KB	koenvw

Comments

Comment #1

rszrama commented 10 July 2009 at 22:00

+1 to this change. I was confused by the language "Allow" vs. the behavior of the form. I wonder if it would be better to make it a radios element, though, with the options:

Do not allow personal messages.
Allow a personal message.
Require a personal message.

Then there's no confusion about the two checkboxes.

Comment #2

rszrama commented 10 July 2009 at 22:02

Title:	Personal Message Field Validation Does not Respect #required	» Provide option for personal messages to be disabled, enabled, and required
Category:	bug	» feature
Status:	Needs review	» Needs work

Further input... fwiw, if the field is required, there's no good reason to check in the validate handler if it's actually been filled in unless you trim spaces off the end of the message to see if actual text was included. Also, this is a feature request and needed a more descriptive title.